Skip to content

London | ITP-May-2026 | Carolina Villa | Sprint 1 | Form Task #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caro-vh wants to merge 16 commits into
base: main
Choose a base branch
from
Open

London | ITP-May-2026 | Carolina Villa | Sprint 1 | Form Task #1295

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9e12162
Project Setup
caro-vh May 14, 2026
10dcfdb
Name and email inputs
caro-vh May 15, 2026
922ea09
Color Selection
caro-vh May 15, 2026
04d8cc1
Colour and Size selection
caro-vh May 15, 2026
4a6cd68
style: Increase margin between form groups
caro-vh May 15, 2026
5d1fad6
fix: wrap each choice with a div command
caro-vh May 15, 2026
46c4e88
style: made space between colour choices wider for accesibility
caro-vh May 15, 2026
8282146
fix: delate comments
caro-vh May 15, 2026
9420646
enable "Format on Save" in VS Code
caro-vh May 21, 2026
fc8488d
change the pattern in name form to accept two caracters separated by …
caro-vh May 21, 2026
f15af4d
fix: wrap <input> element inside <label> for a cleaner look
caro-vh May 21, 2026
0b752c0
removed HomeworkFixErrors branch
caro-vh May 22, 2026
3758890
enable automatic formating
caro-vh May 24, 2026
438c796
fix: intall formatter and test it
caro-vh Jun 3, 2026
42cfc84
process header rules
caro-vh Jun 11, 2026
02a20ab
Fix: remove _headers file
caro-vh Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 51 additions & 7 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,66 @@
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="stylesheet" href="style.css" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<div>
<label for="full-name">Name</label>
<input
type="text"
id="full-name"
name="full-name"
required
minlength="2"
pattern=".*\S,*\S.*"

@cjyuan cjyuan May 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this pattern so that it can also accept a name like "C J" (two characters separated by a space)?

@caro-vh caro-vh May 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I'll have a look and fix it.

title="Please enter at least two nonspace characters">
</div>
<div>
<label for="email">Email</label>
<input
type="email"
id="email"
name="email"
required>
</div>
<div class="tshirt-colour">
<legend>T-shirt Colour</legend>
<div>
<input type="radio" id="red" name="colour" value="red" required>
<label for="red">red</label>

@cjyuan cjyuan May 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: If you wrap the <input> element inside <label>, you would not need to introduce id.

@caro-vh caro-vh May 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I thought it was necessary for an easier manipulation in CSS, thank you for letting me know

</div>
<div>
<input type="radio" id="green" name="colour" value="green" required>
<label for="green">green</label>
</div>
<div>
<input type="radio" id="blue" name="colour" value="blue" required>
<label for="blue">blue</label>
</div>
</div>
<div>
<label for="size">T-shirt Size</label>
<select id="size" name="size" required>
<option value="">Select size</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</div>
<button type="submit">Confirm Order</button>

</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>Carolina Maday Villa Huanca</p>
</footer>
</body>
</html>
</html>
27 changes: 27 additions & 0 deletions Form-Controls/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
body {
background-color: #FFFFE0;
font-family: Arial, sans-serif;
display: block;
margin: 50px 0 0 50px;
padding: 10px 20px 10px 20px;
}
div{
margin-bottom: 20px;

}
.tshirt-colour{
margin-bottom: 15px;
display: centred;
align-items: center;
}
input[type="radio"] {
margin-right: 10px;
width: 20px;
height: 20px;
cursor: pointer;
}
label{
padding: 10px 0;
display: inline-block;
cursor: pointer;
}
Loading