London | 26-ITP-May | Yonatan Teklemariam | Sprint 3 | Implement and re-write tests#1381
London | 26-ITP-May | Yonatan Teklemariam | Sprint 3 | Implement and re-write tests#1381Yonatanteklemariam wants to merge 7 commits into
Conversation
Yonatanteklemariam
added
Complete
Yonatanteklemariam
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good.
Can you revert the changes made in the 2-practice-tdd folder? I think they belong to a separate PR.
| // Special cases: non-number strings | ||
| test(`should return false for non-numeric strings`, () => { | ||
| expect(isProperFraction("a", 5)).toEqual(false); | ||
| expect(isProperFraction(3, "b")).toEqual(false); | ||
| }); |
There was a problem hiding this comment.
What do you mean by "non-numeric strings"? Is "3e2" a non-numeric string?
cjyuan
added
Reviewed
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Remove check for zero numerator in isProperFraction function.
2 participants
Learners, PR Template
Self checklist
Changelist
Defined a new function based on the instruction and wrote tests to verify the output matches the expected target output.
Questions