Skip to content

JSM: answer the permission letter questions with No - #1838

Merged
tarunnjoshi merged 1 commit into
devfrom
jsm-permission-letters-no
Oct 19, 2026
Merged

tarunnjoshi merged 1 commit into
devfrom
jsm-permission-letters-no

Conversation

@tarunnjoshi

Copy link
Copy Markdown
Member

Related to coloredcow-admin/goonj-crm#390 (client request, 19 Oct 2026)

What

Intents created from the engagement (JSM) form now answer the permission letter question with No:

Intent Field Value
Individual Collection Camp "Do you require permission letters from Goonj to get permission from authorities for organizing camps?" (Collection_Camp_Intent_Details.Do_you_require_permission_letters_from_Goonj_to_get_permission_f) No
Individual Dropping Center "Some volunteers require permission letters from Goonj to get permission from authorities for Dropping Center. Do you need one too?" (Dropping_Centre.Some_volunteers_require_permission_letters_from_Goonj_to_get_per) No

Two lines in EngagementIntentTransferService. The value is set by option name (No), the same way the institution dropping center already sets its permission letter question.

Checks

  • Same field everywhere: both fields and their options (1 = Yes, 2 = No) are identical on local, staging and production. Checked with read-only SELECTs. No configuration is needed on any environment.
  • Local, old vs new code, same cases: the only difference in the created intents is the new "No" answer. Every other field is unchanged.
    • New person, Collection Drive → camp: permission letters = No.
    • Inducted volunteer, Provide space → dropping center: permission letters = No.
    • Inducted volunteer, Collection Drive + Provide space → camp No, dropping center No.
  • Review forms: both questions are already on "Collection Camp Intent Review" and "Dropping Center Intent Review", so the team sees "No" pre-filled and can still change it.
  • Other forms: the public and back-end intent forms don't use this code, so they are untouched.

Deploy

Normal deploy only. No configuration, no new hooks, no cache clear.

🤖 Generated with Claude Code

The client asked (19 Oct 2026) that intents created from the engagement
form answer the permission letter question with No:

- Individual Collection Camp: "Do you require permission letters from
  Goonj to get permission from authorities for organizing camps?"
- Individual Dropping Center: "Some volunteers require permission letters
  from Goonj to get permission from authorities for Dropping Center. Do
  you need one too?"

Both fields and their Yes/No options are the same on local, staging and
production. They are set by option name, as the institution dropping
center already does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b0f25cb6-3771-487d-bdc5-91e78658499b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tarunnjoshi
tarunnjoshi merged commit 65dd300 into dev Oct 19, 2026
3 checks passed
@tarunnjoshi
tarunnjoshi deleted the jsm-permission-letters-no branch October 19, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant