Conversation
SaltyKarl
changed the title
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-34774885327.zip |
github-actions
Bot
added
the
Download in Comments
N7Huntsman
approved these changes
Sep 15, 2026
N7Huntsman
left a comment
N7Huntsman
left a comment
Contributor
There was a problem hiding this comment.
Fixes the issue for me.
mszabo-wikia
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions
none
Changes
CheckCellForCollisionandImpactSomethingif (Map.GetLightingTracker().HighestCoverAt(cell) < ExactPosition.y)to if(Map.GetLightingTracker().HighestCoverAt(pos) > Mathf.Min(LastPos.y, ExactPosition.y))so it checks all pos in a tick instead of only pos in tick endReferences
https://discord.com/channels/278818534069501953/668604879526428713/1545745273173708891
Reasoning
does not apply logic bug
Alternatives
different way to rewrite the logic
Testing
Check tests you have performed: