feat(theme): force dark-only mode launcher-wide#561
Open
Kosinkadink wants to merge 1 commit into
Open
Conversation
The launcher's brand redesign is dark-only. Drop the [data-theme=light] CSS block, simplify useTheme() to stamp data-theme=dark on the documentElement, and have resolveTheme() always return 'dark'. Remove the theme picker field and the nativeTheme listener from the settings handler. The Theme / ResolvedTheme types and the theme-changed / get-resolved-theme IPC channels stay in place for ABI compatibility (the title-bar bridge still pushes a per-page bg/text colour for the install's own ComfyUI theme), but they never fire from the launcher itself. Amp-Thread-ID: https://ampcode.com/threads/T-019e2e15-31f3-704e-acf3-d3dac18b6622 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on top of #560 (brand redesign integration). The launcher's brand redesign is dark-only, so this PR drops the runtime theme switch:
src/renderer/src/assets/main.css: remove[data-theme=light]blocksrc/renderer/src/composables/useTheme.ts: stampdata-theme=darkon the documentElement; no IPC roundtrip, no listenersrc/main/lib/ipc/shared.ts:resolveTheme()always returns'dark'src/main/lib/ipc/registerSettingsHandlers.ts: drop the theme picker field and thenativeTheme.on('updated')listener;set-setting('theme', ...)no longer rebroadcastsThe
Theme/ResolvedThemetypes and thetheme-changed/get-resolved-themeIPC channels stay in place for ABI compatibility — the title-bar bridge still pushes a per-page bg/text colour for the install's own ComfyUI theme — but the launcher itself never fires them.Verification
pnpm run typecheck✅pnpm run lint✅pnpm run build✅pnpm run test(937/937) ✅