Skip to content

add cleanup observable and use it in generate stories - #2951

Open
silouone wants to merge 6 commits into
masterfrom
remove-stale-folder-stories-when-generating-storybook
Open

add cleanup observable and use it in generate stories#2951
silouone wants to merge 6 commits into
masterfrom
remove-stale-folder-stories-when-generating-storybook

Conversation

@silouone

@silouone silouone commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

Detailed purpose of the PR

  • Update the generate storybook script and specifly the generated stories to support the removal of stale folder & stories files for stale components ( often the case when having multiple PR to review and switching back and forth to use the storybook

Result and observation

  • Breaking changes ?
    If checked, what have you broken ?

  • Extra lib ?
    If checked, Which extra lib did you add ? (name, purpose, link ...).

Testing Strategy

  • Already covered by tests
  • Manual testing
  • Unit testing

@silouone
silouone requested a review from adamska27 March 27, 2025 12:28
@codecov

codecov Bot commented Mar 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.48%. Comparing base (f2d1c6b) to head (5494743).
⚠️ Report is 1100 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2951      +/-   ##
==========================================
- Coverage   95.04%   93.48%   -1.56%     
==========================================
  Files         537      434     -103     
  Lines        8898     6789    -2109     
  Branches      467      472       +5     
==========================================
- Hits         8457     6347    -2110     
  Misses        359      359              
- Partials       82       83       +1     

see 116 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b7c94...5494743. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/@coorpacademy-components/scripts/observables/generate-stories.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants