Skip to content

CV: support cosmos ledger app protocol update - #1152

Open
chillyvee wants to merge 1 commit into
CosmosContracts:mainfrom
chillyvee:cv28
Open

CV: support cosmos ledger app protocol update#1152
chillyvee wants to merge 1 commit into
CosmosContracts:mainfrom
chillyvee:cv28

Conversation

@chillyvee

@chillyvee chillyvee commented May 1, 2025

Copy link
Copy Markdown
Contributor

The most recent Cosmos Ledger App requires a protocol update for ledger connection and signing.

Summary by CodeRabbit

  • Chores
    • Updated dependencies to use a specific version of a library.

@coderabbitai

coderabbitai Bot commented May 1, 2025

Copy link
Copy Markdown

Walkthrough

The go.mod file was updated to include a new module replacement directive. The directive specifies that the module github.com/zondax/ledger-go should be replaced with version v1.0.0. No other changes or removals were made to the file, and no public or exported entities were altered.

Changes

File Change Summary
go.mod Added a replace directive for github.com/zondax/ledger-go to use version v1.0.0.

Poem

A hop to the mod, a leap to replace,
Ledger-go now finds its proper place.
With version one-point-oh, we bound ahead,
Dependencies tidy, no more dread!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
go.mod (1)

239-241: Add explanatory comment for the new replace directive.

For consistency with adjacent entries, include a comment above this line explaining why github.com/zondax/ledger-go is being pinned to v1.0.0 (e.g., // Support Cosmos Ledger App protocol update). This will help future maintainers understand the intent.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4276738 and 60d203f.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build-docker
  • GitHub Check: lint
🔇 Additional comments (2)
go.mod (2)

240-240: Replace directive correctly pins the module version.

This update correctly overrides the existing github.com/zondax/ledger-go requirement to version v1.0.0 to support the Cosmos Ledger App protocol update as intended.


240-240:

Details

✅ Verification successful

Verify that v1.0.0 exists upstream.

Please confirm that the v1.0.0 tag is published on the github.com/zondax/ledger-go repository.
You can run:


🏁 Script executed:

#!/usr/bin/env bash
# Verify the v1.0.0 tag exists without cloning the full repo
git ls-remote https://github.com/zondax/ledger-go.git | grep 'refs/tags/v1.0.0'

Length of output: 137


Confirmed v1.0.0 tag exists upstream for github.com/zondax/ledger-go. No further action needed.

@vexxvakan

Copy link
Copy Markdown
Member

I currently do not have a Ledger device so I can not verify this, but in general this looks good to me! Is there any source for the cosmos ledger app update or other chains starting to use it?

@dimiandre can you check this out real quick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants