CV: support cosmos ledger app protocol update - #1152
Conversation
WalkthroughThe Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
go.mod (1)
239-241: Add explanatory comment for the new replace directive.For consistency with adjacent entries, include a comment above this line explaining why
github.com/zondax/ledger-gois being pinned tov1.0.0(e.g.,// Support Cosmos Ledger App protocol update). This will help future maintainers understand the intent.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build-docker
- GitHub Check: lint
🔇 Additional comments (2)
go.mod (2)
240-240: Replace directive correctly pins the module version.This update correctly overrides the existing
github.com/zondax/ledger-gorequirement to versionv1.0.0to support the Cosmos Ledger App protocol update as intended.
240-240:Details
✅ Verification successful
Verify that
v1.0.0exists upstream.Please confirm that the
v1.0.0tag is published on thegithub.com/zondax/ledger-gorepository.
You can run:
🏁 Script executed:
#!/usr/bin/env bash # Verify the v1.0.0 tag exists without cloning the full repo git ls-remote https://github.com/zondax/ledger-go.git | grep 'refs/tags/v1.0.0'Length of output: 137
Confirmed v1.0.0 tag exists upstream for
github.com/zondax/ledger-go. No further action needed.
|
I currently do not have a Ledger device so I can not verify this, but in general this looks good to me! Is there any source for the cosmos ledger app update or other chains starting to use it? @dimiandre can you check this out real quick? |
The most recent Cosmos Ledger App requires a protocol update for ledger connection and signing.
Summary by CodeRabbit