feat(gradebook): By-weight view with Configure Weights dialog#8413
Draft
LWS49 wants to merge 15 commits into
Draft
feat(gradebook): By-weight view with Configure Weights dialog#8413LWS49 wants to merge 15 commits into
LWS49 wants to merge 15 commits into
Conversation
…alog, toolbar buttons, visibility state, and tests
- Add MuiColumnPickerDialog with Apply/Export actions, locked-column enforcement, and optional dataColumnIds hint when no data columns are selected
- Update MuiTableToolbar to render a trigger button (opens dialog) and a direct export button alongside the existing CSV download icon
- Extend useTanStackTableBuilder with column visibility state (localStorage persistence, dynamic reconciliation), onExportFromPicker, onDirectExport, and cross-page selection helpers (selectedCount, toggleAllFiltered, etc.)
- Add ColumnPickerTemplate interface and Body.ts selection fields
- Add full test coverage for dialog, toolbar, and hook behaviour
- Add lib.components.table.* locale keys (en/ko/zh)
- Add gradebook_weight (0-100 integer) column to course_assessment_tabs - Add Course::Settings::GradebookComponent with weighted_view_enabled - Add manage_gradebook_weights/settings abilities (manager/owner only) - Add Course Admin -> Gradebook settings page to toggle the setting
- add Tab.update_gradebook_weights: transactional bulk update scoped to course tabs, with pre-flight ID validation and single pre-fetch query - extend GET /gradebook index JSON with weightedViewEnabled, canManageWeights, and per-tab gradebookWeight (gated by setting) - add PATCH /gradebook/weights: manager-only, returns 422 on validation failure or foreign tab, transactionally rolls back on any error
…e map, unused prop, viewMode reset
LWS49
force-pushed
the
lws49/feat-gradebook-weights-pr2-api
branch
5 times, most recently
from
333c45a to
8b79b30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[All assessments | By weight]toolbar toggle (rendered only when the course-level setting from PR 1 is enabled)Architecture
computeWeighted.ts) —computeTabSubtotal,computeStudentTotal,sumWeightsweightedViewEnabled,canManageWeights,gradebookWeightper tab;updateTabWeightsactionGradebookWeightedTable— self-contained table with custom 3-row thead; no column picker (all subtotals always visible)ConfigureWeightsDialog— dispatchesupdateGradebookWeightsthunk → PATCH/gradebook/weightsGradebookIndex— readsweightedViewEnabledselector; conditionally rendersToggleButtonGroup+ swaps table component