Repository navigation
Preserve suffix after a replacement at the range boundary - #151
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A supported ranged string replacement can silently discard text after the replacement range when the last match ends exactly at that range's boundary:
The suffix was copied only when another loop iteration found no match. If the final match consumed the replacement range, that iteration never occurred.
Change
Track the consumed source position and copy the unconsumed suffix after the replacement loop. This preserves the suffix both when the loop exits at a match boundary and when it finds no further match. Add comparison cases for removal, expansion, repeated matches, a remaining in-range character, and a match at the end of the builder. Unity source is updated through the existing netstandard2.1 post-build copy target.
Validation
DOTNET_ROLL_FORWARD=Majorbecause .NET 7 runtime is unavailable locally. No Unity editor/TMP/IL2CPP execution.