Repository navigation
Correct UTF8 builder return types in API reference - #153
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction
The
Utf8ValueStringBuilderreference lists character-based return types for five byte-buffer APIs. This contradicts their actual public signatures and gives the wrong types to callers using the advertised direct-buffer path.Change only those five cells to
ReadOnlySpan<byte>,ReadOnlyMemory<byte>,ArraySegment<byte>,Memory<byte>, andSpan<byte>. The UTF16 reference remains unchanged.Validated against the public signatures and an isolated .NET fixture that assigns each return value to its documented byte-based type. No runtime behavior changes.