Repository navigation
fix: avoid claiming embedded Turnstile is solved - #531
Open
dannyward630 wants to merge 1 commit into
Open
dannyward630 wants to merge 1 commit into
dannyward630 wants to merge 1 commit into
Conversation
Embedded Turnstile widgets can remain on pages after solving, so their presence cannot establish that the challenge is cleared. Make _challenge_cleared rely only on detected challenge content and log embedded results as unverifiable. Add sync and async regression coverage.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded Turnstile widgets can remain on pages after solving, so their presence cannot establish that the challenge is cleared. Make _challenge_cleared rely only on detected challenge content and log embedded results as unverifiable. Add sync and async regression coverage.
Proposed change
Embedded Turnstile scripts can remain in the page whether a challenge is solved or not. The previous embedded-challenge shortcut therefore reported success without evidence. This change treats a challenge as cleared only when no Cloudflare challenge is detected, and reports embedded solver outcomes as unverifiable while returning the page unchanged. Sync and async regression tests cover this behavior.
Type of change:
Additional information
Validation:
AI disclosure: Codex (GPT-6) generated and edited the implementation and regression tests, ran the validations above, and drafted this description. The patch has not received human review yet.
Checklist: