Skip to content

added an octave manager for more complex(?) RTTTL #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PlantLily wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added an octave manager for more complex(?) RTTTL #2

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce1d0e0
added an octave manager for more complex(?) RTTTL
May 8, 2017
73c8205
added oct variable, improved silly method
May 9, 2017
76c9d9a
updated oct variable, got rid of a bit of unnecessary code
May 9, 2017
b59e70e
Update main.js
May 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,14 @@ function parseSong(songString, settings) {
var songNote = songData[i].replace(".", "");
var match = pattern.exec(songNote);
var dot = 0;


//octave manager
if(isNaN(oct) == false){

@DDRBoxman DDRBoxman May 8, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does oct get set?

@PlantLily PlantLily May 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright added oct to it
and changed the refinement of octave, sorry I'm really tired

octave = octave*1 + (oct*1-octave*1);
}else{
var octave = settings.getOctave();

@DDRBoxman DDRBoxman May 8, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't redefine octave within the else scope

}

if(songData[i].indexOf('.') !== -1) {
dot = 1;
}
Expand Down