Repository navigation
fix(klipper): send X-Api-Key header on all Moonraker requests - #30
Merged
DMontgomery40 merged 1 commit intoOct 6, 2026
Merged
Conversation
Owner
|
Thank you, Jack—this was a useful fix! Your Klipper 0.13.0 report and the 401-to-ready evidence identified exactly why authenticated Moonraker installs could not work. Your original commit is now merged through #31, and you’re credited in CONTRIBUTORS.md. I added loopback regressions covering all nine request paths, including multipart uploads and the remote download used by print inspection. Both API-key and trusted-client configurations pass, and CI is green on Node 18/20/22/24. No maintainer physical print was run. The fix is now published in 1.2.11. Trusted npm publication succeeded, and a fresh npx installation starts with version 1.2.11 and discovers all 30 MCP tools. Really appreciate the focused contribution and concrete evidence! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The Klipper adapter accepted an
apiKeyparameter but ignored it. Its shared Axios client has no default authentication headers, while only the OctoPrint backend attaches credentials per request. Moonraker instances with[authorization] force_logins: Truetherefore returned401 Unauthorizedfor every Klipper-backend call.Fix
X-Api-Keyon all Klipper/Moonraker GET and POST requests.Verification
npm run buildpasses.FULU Orca slicer aliases export Bambu project 3MF with model presetandempty slicer_path preserves env fallback without enabling executable arguments).force_logins: True;get_printer_statusreturned 401 before the fix and printer-ready status JSON after it.