[Draft] [Port to dspace-7_x] Prevent double rendering dynamic themes#4230
Closed
LotteHofstede wants to merge 2 commits into
Closed
[Draft] [Port to dspace-7_x] Prevent double rendering dynamic themes#4230LotteHofstede wants to merge 2 commits into
LotteHofstede wants to merge 2 commits into
Conversation
LotteHofstede
force-pushed
the
4123-duplicate-theme-rendering_contibute-7.x
branch
from
cfd5419 to
0a4f0b9
Compare
|
Hi @LotteHofstede, |
|
Hi @LotteHofstede, closing out this PR since unfortunately DSpace 7.x is now end-of-life after the release of 10.0 (see DSpace Software Support Policy). However, if you'd like it to be considered feel free to re-open the PR against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
The code changes in this PR forego setting an initial theme when dynamic themes are enabled. This way, when initially loading a page, it won't briefly show the base theme before rendering the dynamically configurated theme.
Instructions for Reviewers
When hard refreshing a page with a dynamically set theme, the base theme won't be briefly loaded anymore.