Skip to content

Refactoring lampposts - #1373

Open
chazzyjazzy wants to merge 11 commits into
DarkPack13:masterfrom
chazzyjazzy:lamppost
Open

Refactoring lampposts#1373
chazzyjazzy wants to merge 11 commits into
DarkPack13:masterfrom
chazzyjazzy:lamppost

Conversation

@chazzyjazzy

Copy link
Copy Markdown
Contributor

About The Pull Request

refactors lampposts to be an /obj/machinery/light/floor so that they don't snowflake their own light creation by creating several light decals for every one lamppost and instead uses /tg/ light logic

dreamseeker_nFoUcWkkHB dreamseeker_8v8GxJpXSO dreamseeker_zNa8ZcpfPw

Why It's Good For The Game

reduce lighting subsystem CPU usage? more sane lampposts i guess

Changelog

🆑

refactor: lampposts are now an /obj/machinery/light/floor instead of an /obj/structure, please run the updatepaths script!!!

/:cl:

@FalloutFalcon FalloutFalcon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not even sure anyone will notice that they arent 4 lights anymore.
Might still be nice to make them diffrent power or range or something tho? shrug,

Comment thread tools/UpdatePaths/Scripts/DarkPack/1373_lamppost_refactor.txt Outdated

@KCartridge KCartridge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapping lgtm

Comment thread modular_darkpack/modules/decor/code/decor.dm Outdated
TheCarnalest and others added 2 commits August 25, 2026 10:29
Co-authored-by: TheCarnalest <167369312+TheCarnalest@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants