DT-3098: (Re-)Add PI Email to Study

[rushtong]

Addresses

https://broadworkbench.atlassian.net/browse/DT-3098

Summary

This PR fixes a bug where the study PI Email that is sent from the UI is not saved on the back end.

Originally, there was a PI Email as a top level study property in the dataset registration schema json file. It was also present in the corresponding java file and in the Swagger documentation. It was removed soon afterward from the schema and from java, but left behind in the documentation. The UI functionality to bring that back relied on the swagger contract, but the code did not have support for it.

This PR brings that field back and allows for it to be populated and updated based on the schema. It is queried, mapped, and returned in study objects as a top level field.

Since the UI was expecting this to be the case, there are no required changes there.

---

Have you read CONTRIBUTING.md lately? If not, do that first.

• Label PR with a Jira ticket number and include a link to the ticket
• Label PR with a security risk modifier [no, low, medium, high]
• PR describes scope of changes
• Get a minimum of one thumbs worth of review, preferably two if enough team members are available
• Get PO sign-off for all non-trivial UI or workflow changes
• Verify all tests go green
• Test this change deployed correctly and works on dev environment after deployment

[Copilot]

Pull request overview

This pull request restores support for a top-level Study piEmail field by reintroducing it into the dataset registration schema, persisting it in the study table, and threading it through the service/DAO layers so it can be created, updated, patched, and returned in Study objects.

Changes:

• Add nullable pi_email column to the study table via Liquibase and wire it into StudyDAO insert/update and study-loading queries.
• Reintroduce piEmail into the dataset registration JSON schema and the generated DatasetRegistrationSchemaV1 model, mapping it to/from Study.
• Extend patch/update flows and tests to cover piEmail propagation (plus additional service/DAO test additions included in this PR).

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/main/java/org/broadinstitute/consent/http/db/DatasetDAO.java	Select s.pi_email AS s_pi_email so nested Study hydration includes PI email.
src/main/java/org/broadinstitute/consent/http/db/StudyDAO.java	Add pi_email to insert/update and adjust study query used for hydration.
src/main/java/org/broadinstitute/consent/http/models/Study.java	Add piEmail field with getter/setter.
src/main/java/org/broadinstitute/consent/http/models/StudyConversion.java	Add piEmail and include it when creating a study stub.
src/main/java/org/broadinstitute/consent/http/models/StudyPatch.java	Add piEmail patch field and patchability check.
src/main/java/org/broadinstitute/consent/http/models/dataset_registration_v1/DatasetRegistrationSchemaV1.java	Add piEmail to the registration schema model (JSON mapping, equals/hashCode/toString).
src/main/java/org/broadinstitute/consent/http/models/dataset_registration_v1/builder/SchemaFromStudy.java	Map Study.piEmail into the outgoing registration schema.
src/main/java/org/broadinstitute/consent/http/service/DatasetRegistrationService.java	Include piEmail in study insert/update objects built from registration.
src/main/java/org/broadinstitute/consent/http/service/DatasetService.java	Include piEmail when inserting/updating studies during dataset→study conversion.
src/main/java/org/broadinstitute/consent/http/service/dao/DatasetServiceDAO.java	Add piEmail to StudyInsert/StudyUpdate records and patch conversion logic.
src/main/resources/changelog-master.xml	Include the new Liquibase changeset.
src/main/resources/changesets/changelog-consent-2026-06-02-study-pi-email.xml	New changeset adding study.pi_email.
src/main/resources/dataset-registration-schema_v1.json	Re-add piEmail as an (optional) email-formatted field.
src/test/java/org/broadinstitute/consent/http/db/DatasetDAOTest.java	Update test inserts to account for the new pi_email column.
src/test/java/org/broadinstitute/consent/http/db/StudyDAOTest.java	Update study insert/update tests to include piEmail parameter position.
src/test/java/org/broadinstitute/consent/http/models/StudyConversionTest.java	New unit tests covering StudyConversion behavior including PI email.
src/test/java/org/broadinstitute/consent/http/models/StudyPatchTest.java	Update patch tests for new constructor signature and add PI email patchability coverage.
src/test/java/org/broadinstitute/consent/http/service/DatasetRegistrationServiceTest.java	Add assertions that PI email is captured in study insert/update and add dataset patch tests.
src/test/java/org/broadinstitute/consent/http/service/DatasetServiceTest.java	Add/extend service tests (includes dataset→study conversion and patch exception coverage).
src/test/java/org/broadinstitute/consent/http/service/dao/DatasetServiceDAOTest.java	Update DAO tests to include PI email in study insert/update/patch flows.

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[otchet-broad]

Nice work. Great catch.

[otchet-broad]

Nice