Skip to content

Disallow AgentTracer.forceRegister(null)#11942

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/disallow-forceregister-null
Jul 14, 2026
Merged

Disallow AgentTracer.forceRegister(null)#11942
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/disallow-forceregister-null

Conversation

@mcculls

@mcculls mcculls commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Disallow AgentTracer.forceRegister(null); callers should pass NOOP_TRACER explicitly instead of null.

Motivation

Helps ensure AgentTracer.get() is never null

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Callers should pass NOOP_TRACER explicitly instead of null.
@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Jul 14, 2026
@mcculls mcculls requested review from a team as code owners July 14, 2026 09:47
@mcculls mcculls requested review from jpbempel and mtoffl01 and removed request for a team July 14, 2026 09:47

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

PR tightens the null-safety contract of AgentTracer.forceRegister() by rejecting null with a clear error message, ensuring AgentTracer.get() never returns null. All two existing usages of forceRegister(null) are updated in this diff to pass NOOP_TRACER explicitly; no call sites outside the repository depend on the previous null-accepting behavior.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 5bfb1ae · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-prod-us1-5

This comment has been minimized.

@pr-commenter

pr-commenter Bot commented Jul 14, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1784022850 1784023197
end_time 2026-07-14T09:55:36 2026-07-14T10:01:23
git_branch master mcculls/disallow-forceregister-null
git_commit_sha 871f5b6 5bfb1ae
start_time 2026-07-14T09:54:11 2026-07-14T09:59:58
See matching parameters
Baseline Candidate
ci_job_id 1857177222 1857177222
ci_pipeline_id 124489867 124489867
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1784022015 1784022015

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-59.604µs; +24.471µs] or [-19.409%; +7.969%]
unstable
[-72.119µs; +31.625µs] or [-20.434%; +8.960%]
unstable
[-86.298µs; +38.396µs] or [-23.239%; +10.340%]
unstable
[-277.831µs; +426.876µs] or [-20.676%; +31.767%]
same
scenario:basic same same same unstable
[-64.420µs; +225.104µs] or [-5.461%; +19.081%]
unstable
[-113.966op/s; +235.917op/s] or [-4.673%; +9.673%]
scenario:loop same same same same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (352.941 µs) : 289, 417
.   : milestone, 353,
basic (296.101 µs) : 288, 304
.   : milestone, 296,
loop (8.987 ms) : 8981, 8994
.   : milestone, 8987,
section candidate
noprobe (332.694 µs) : 305, 361
.   : milestone, 333,
basic (295.092 µs) : 288, 302
.   : milestone, 295,
loop (8.985 ms) : 8981, 8990
.   : milestone, 8985,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 352.941 µs [288.992 µs, 416.89 µs]
basic 296.101 µs [287.744 µs, 304.459 µs]
loop 8.987 ms [8.981 ms, 8.994 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 332.694 µs [304.882 µs, 360.506 µs]
basic 295.092 µs [288.493 µs, 301.691 µs]
loop 8.985 ms [8.981 ms, 8.99 ms]

@dd-octo-sts

dd-octo-sts Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.95 s 13.98 s [-0.9%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.85 s 13.03 s [-2.0%; -0.8%] (maybe better)
startup:petclinic:appsec:Agent 16.97 s 16.56 s [+1.4%; +3.5%] (significantly worse)
startup:petclinic:iast:Agent 16.94 s 16.92 s [-0.7%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 16.50 s 16.92 s [-3.6%; -1.4%] (significantly better)
startup:petclinic:sca:Agent 16.98 s 16.54 s [+1.7%; +3.6%] (significantly worse)
startup:petclinic:tracing:Agent 16.12 s 16.04 s [-0.4%; +1.3%] (no difference)

Commit: 5bfb1aef · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mcculls mcculls enabled auto-merge July 14, 2026 12:13
@mcculls mcculls added this pull request to the merge queue Jul 14, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 14, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-14 16:09:46 UTC ℹ️ Start processing command /merge


2026-07-14 16:09:51 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-14 17:15:44 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 14, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 1913e33 into master Jul 14, 2026
603 of 604 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the mcculls/disallow-forceregister-null branch July 14, 2026 17:15
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants