Disallow AgentTracer.forceRegister(null)#11942
Disallow AgentTracer.forceRegister(null)#11942gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
AgentTracer.forceRegister(null)#11942Conversation
Callers should pass NOOP_TRACER explicitly instead of null.
There was a problem hiding this comment.
More details
PR tightens the null-safety contract of AgentTracer.forceRegister() by rejecting null with a clear error message, ensuring AgentTracer.get() never returns null. All two existing usages of forceRegister(null) are updated in this diff to pass NOOP_TRACER explicitly; no call sites outside the repository depend on the previous null-accepting behavior.
🤖 Datadog Autotest · Commit 5bfb1ae · What is Autotest? · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (352.941 µs) : 289, 417
. : milestone, 353,
basic (296.101 µs) : 288, 304
. : milestone, 296,
loop (8.987 ms) : 8981, 8994
. : milestone, 8987,
section candidate
noprobe (332.694 µs) : 305, 361
. : milestone, 333,
basic (295.092 µs) : 288, 302
. : milestone, 295,
loop (8.985 ms) : 8981, 8990
. : milestone, 8985,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
1913e33
into
master
What Does This Do
Disallow
AgentTracer.forceRegister(null); callers should passNOOP_TRACERexplicitly instead of null.Motivation
Helps ensure
AgentTracer.get()is nevernullContributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]