[SDTEST-3751] Optimize split-aware parallelism planning#60
Open
anmarchenko wants to merge 9 commits into
Open
Conversation
anmarchenko
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97267de802
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DDTest now chooses planned parallel runner count by evaluating weighted test splits instead of linearly interpolating from saved/skippable time. The split scheduler is shared between runner-count scoring and final split generation, and the README explains the new planning behavior.
Why
The previous runner-count calculation could over-provision workers for suites where additional runners did not reduce the slowest runner's estimated wall time. Scoring candidate splits by slowest-runner time, then imbalance, avoids launching workers that would sit idle.
E2E testing
Run
ddtest plan --platform ruby --framework rspec --min-parallelism 2 --max-parallelism 4on a project with weighted runnable test files, then inspect.testoptimization/runner/parallel-runners.txtand.testoptimization/runner/tests-split/runner-*to confirm the chosen runner count matches the fastest and most even estimated split. Validation performed:go test ./internal/runner,go test ./internal/runner -run '^$' -bench BenchmarkCalculateParallelRunners20000TestFiles -benchtime=1x,make test, andmake lint.