-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enhance Datadog API key configuration instructions #36520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
litianningdatadog
wants to merge
1
commit into
master
Choose a base branch
from
litianningdatadog-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -63,7 +63,7 @@ | |||||||||
|
|
||||||||||
| 5. Configure the Datadog API key | ||||||||||
|
|
||||||||||
| Datadog recommends saving the Datadog API key in AWS Secrets Manager for security and easy rotation. The key needs to be stored as a plaintext string (not a JSON blob). Ensure your Lambda functions have the required `secretsmanager:GetSecretValue` IAM permission. | ||||||||||
| Datadog recommends saving the Datadog API key in AWS Secrets Manager for security and easy rotation. Ensure your Lambda functions have the required `secretsmanager:GetSecretValue` IAM permission. | ||||||||||
|
Check warning on line 66 in content/en/serverless/aws_lambda/instrumentation/python.md
|
||||||||||
|
|
||||||||||
| ```sh | ||||||||||
| export DATADOG_API_KEY_SECRET_ARN="<DATADOG_API_KEY_SECRET_ARN>" | ||||||||||
|
|
@@ -74,6 +74,15 @@ | |||||||||
| ```sh | ||||||||||
| export DATADOG_API_KEY="<DATADOG_API_KEY>" | ||||||||||
| ``` | ||||||||||
| The Datadog Lambda Extension supports two formats for the secret value: | ||||||||||
| - Plain string — the secret value is used directly as the API key. | ||||||||||
| - JSON object — if the secret value is a JSON object, the extension extracts the `dd_api_key` field and uses its value as the API key. This is useful if you store the Datadog API key alongside other credentials in a single | ||||||||||
| secret: | ||||||||||
| ```sh | ||||||||||
| { "dd_api_key": "<YOUR_DATADOG_API_KEY>" } | ||||||||||
| ``` | ||||||||||
| The field name `dd_api_key` is fixed and cannot be customized. If the secret is not valid JSON or does not contain `dd_api_key`, the extension falls back to using the raw secret string, so existing plain-string secrets continue to work unchanged. | ||||||||||
| Note: JSON-formatted secrets require Datadog Lambda Extension v96 or later. | ||||||||||
|
Comment on lines
+84
to
+85
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
|
||||||||||
| 6. Instrument your Lambda functions | ||||||||||
|
|
||||||||||
|
|
||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.