Repository navigation
Conversation
Cargo test locally failed for me with
```
failures:
---- channels::shared_channel::test::shared_drop_cascade_drop_executor_reverse stdout ----
thread 'unnamed-67' (3258883) panicked at glommio/src/channels/shared_channel.rs:140:63:
called Option::unwrap() on a None value
thread 'channels::shared_channel::test::shared_drop_cascade_drop_executor_reverse' (3258791) panicked at glommio/src/channels/shared_channel.rs:944:20:
called Result::unwrap() on an Err value: Thread panicked { .. }
failures:
channels::shared_channel::test::shared_drop_cascade_drop_executor_reverse
```
Couldn't reproduce but Codex explained the issue. The fix seems
sensible.
vlovich
force-pushed
the
deflake-test
branch
from
September 4, 2026 01:10
9a16d56 to
3face4d
Compare
|
vlovich
force-pushed
the
deflake-test
branch
from
September 4, 2026 01:15
3face4d to
9a16d56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deflakes a rare test flake
Motivation
Saw this false-positive test failure:
Related issues
N/A
Additional Notes
Couldn't reproduce but Codex explained the issue. The fix seems sensible.
Checklist
[X] I have added unit tests to the code I am submitting
[X] My unit tests cover both failure and success scenarios
[] If applicable, I have discussed my architecture