feat!: root_span_id handling in otel thread ctx#1834
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits intomainfrom Apr 3, 2026
Merged
feat!: root_span_id handling in otel thread ctx#1834gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits intomainfrom
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
yannham
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
==========================================
+ Coverage 71.48% 71.55% +0.06%
==========================================
Files 426 426
Lines 67304 67350 +46
==========================================
+ Hits 48113 48193 +80
+ Misses 19191 19157 -34
🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: a0d136d | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
ivoanjo
reviewed
Apr 1, 2026
scottgerring
approved these changes
Apr 2, 2026
Member
scottgerring
left a comment
scottgerring
left a comment
There was a problem hiding this comment.
ACK Ivo's comment about the local root span ID being passed as a [u8; 8] , but otherwise LGTM
yannham
force-pushed
the
yannham/thread-ctx-attrs-keys
branch
from
0d88fe6 to
cfba812
Compare
ivoanjo
reviewed
Apr 2, 2026
yannham
force-pushed
the
yannham/thread-ctx-root-span-id
branch
from
c2bc9c6 to
cc1162e
Compare
yannham
force-pushed
the
yannham/thread-ctx-root-span-id
branch
from
cc1162e to
345d0c0
Compare
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Contributor
Author
|
/remove |
|
View all feedbacks in Devflow UI.
|
Contributor
Author
|
Ready to merge, but waiting for #1843 to land which is currently blocking PHP, to avoid a rebase there. |
This reverts commit 7dd922e. After discussion, the spec actually requires UTF8 bytes, so let's enforce that at the type system level.
yannham
force-pushed
the
yannham/thread-ctx-root-span-id
branch
from
7050530 to
a0d136d
Compare
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
yannham/thread-ctx-root-span-id
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend on #1831.
What does this PR do?
Follow-up of #1791. Add special handling of the
root_span_idattribute, which is expected to be always provided by downstream users of libdatadog when publishing a thread context.Motivation
Addresses #1791 (comment).
Additional Notes
Since we want to set it automatically and unconditionally, I've opted for the convention that the corresponding key is always set and is always the first in the string table located in the process context. I believe this is reasonable (since we always want to set this attribute) and achievable as long as we control the process-level context publication. But it might be a tad "magic".
Another possibility is to request the user to provide the key for the
datadog.root_span_idattribute. It is a bit less ergonomic for end-users who need to ensure the key is present, and propagate the index to the code that does the context switching so that it can provide it when calling intolibdatadog.How to test the change?
Tests have been updated to reflect the change.