Repository navigation
[Fix][admin] Fix resource same-name overwrite not refreshing local rs cache - #4565
Merged
Merged
Conversation
Contributor
|
Thanks for the patch, and for tracking down the stale tmp/rs cache. Updating the file size and description on overwrite, and adjusting parent directory size by the delta instead of always adding the new size, fixes a real accounting bug. Clearing the local cache on delete is the right direction as well. A few cases are still open, so this does not fully fix Session jobs reusing an old jar:
We will treat this as an incremental fix and merge it first. The Session classloader cache, a single path helper, unique temp files, and not rolling back a successful remote write should go into a follow-up PR. |
… cache Invalidate tmp/rs after overwrite/delete, rewrite local cache atomically on rs:// load, and correct parent size delta on overwrite so session jobs do not keep using stale jars. Co-authored-by: Cursor <cursoragent@cursor.com>
aiwenmo
force-pushed
the
Fix-rs-local-cache-overwrite
branch
from
October 20, 2026 06:44
fe819bd to
7afabf7
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmp/rslocal cache after resource same-name overwrite / delete so OSS/HDFS updates are picked uprs://local files atomically (delete + temp download + move) and disable URL caches to avoid stale JarFile/ClassLoader content in Session modesTest plan
rs:/...tmp/rs/...is removed/updated after uploadtmp/rscache for that path is cleared