refactor(hygiene): clarify comment-style TODO markers check#125
Open
dembrane-sam-bot wants to merge 3 commits into
Open
refactor(hygiene): clarify comment-style TODO markers check#125dembrane-sam-bot wants to merge 3 commits into
dembrane-sam-bot wants to merge 3 commits into
Conversation
spashii
added a commit
that referenced
this pull request
Jun 28, 2026
…audit) (#130) ## What Adds `CVE-2026-48818` and `CVE-2026-54283` (starlette HIGH) to `.trivyignore` with rationale. ## Why A trivy DB update started flagging `starlette 0.52.1` with two HIGH CVEs, failing the **container scan** on **every open PR** — including docs-only PRs (#124, #125, #127, #128) and blocking the merge queue entirely. `starlette` is a **transitive** dependency (via `google-adk`'s optional FastAPI dev-server). Sam imports no starlette and exposes **no ASGI/FastAPI app** — its only HTTP surface (`/healthz`, `/github/webhook`) runs on **aiohttp**, and the GitHub edge proxy is a separate Cloud Function. Both CVE paths (StaticFiles SSRF; starlette request handling) are unreachable. A direct bump isn't clean: starlette is capped by `google-adk 1.34.0`'s fastapi pin. Ignored with rationale (same pattern as the existing `gh`/krb5 entries); to be dropped when `google-adk` bumps its floor. ## Unblocks All 6 stuck PRs, and the next deploy of `main` to Cloud Run. Co-authored-by: sam-dembrane <sam-dembrane@sam2ks-MacBook-Pro.local> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change?
Clarifies the comment-style TODO markers check in
src/skills/daily-maintenance/skill.mdto specify matching standalone TODOs and explicitly ignore instructional prose or checklists that describe the rule.What did Sam notice that led to this?
During daily-maintenance, the string match for 'TODO' triggered a false positive on daily-maintenance and github-pr-workflow because those files contain the word 'TODO' in their instructional prose rather than as actual code-level comments.
Tier?
Tier 1 (Prose Skill).
Confidence?
100% confident — resolves the false-positive diagnostic ambiguity.