Skip to content

T1283037 - Charts - DashStyle throws a TypeScript error when a combination of dash styles (e.g., 'dashdotdash') is used #34883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexslavr wants to merge 4 commits into
base: main
Choose a base branch
from
Open

T1283037 - Charts - DashStyle throws a TypeScript error when a combination of dash styles (e.g., 'dashdotdash') is used #34883

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1ac65b
Extend the DashStyle type to support any combination of 'dash' | 'dot…
alexslavr Aug 24, 2026
ae7d180
Regenerate dx.all.d.ts
alexslavr Aug 24, 2026
e3d7328
Use inline string literals
alexslavr Aug 25, 2026
14c5988
Revert adding type helpers, regenerate
alexslavr Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/devextreme/js/common/charts.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,12 @@ export type ChartsDataType = 'datetime' | 'numeric' | 'string';
* @public
* @namespace DevExpress.common.charts
*/
export type DashStyle = 'dash' | 'dot' | 'longDash' | 'solid';
export type DashStyle = 'solid'
| 'dash' | 'dot' | 'longDash'
| `${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}`
| `${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}`
| `${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}`
| `${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}${'dash' | 'dot' | 'longDash'}`;

/**
* @public
Expand Down
18 changes: 18 additions & 0 deletions packages/devextreme/js/core/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,24 @@ export type AllPermutations<T extends string> = UnionLength<T> extends PermutedU
[K in T]: Permutations<T> | AllPermutations<Exclude<T, K>>
}[T] : string;

type BuildTuple<Length extends number, Result extends unknown[] = []> = Result['length'] extends Length
? Result
: BuildTuple<Length, [...Result, unknown]>;

type Tail<T extends unknown[]> = T extends [unknown, ...infer Rest] ? Rest : [];

type RepeatUnionInternal<
T extends string,
DepthTuple extends unknown[],
> = DepthTuple['length'] extends 0
? never
: T | `${T}${RepeatUnionInternal<T, Tail<DepthTuple>>}`;

export type RepeatUnion<
T extends string,
Depth extends number,
> = RepeatUnionInternal<T, BuildTuple<Depth>>;

/// #DEBUG

export type EventProps<T> = Extract<keyof T, `on${any}`>;
Expand Down
35 changes: 34 additions & 1 deletion packages/devextreme/ts/dx.all.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2075,7 +2075,9 @@ declare module DevExpress.common.charts {
};
export type ChartsDataType = 'datetime' | 'numeric' | 'string';
export type ChartsLabelOverlap = 'hide' | 'none' | 'stack';
export type DashStyle = 'dash' | 'dot' | 'longDash' | 'solid';
export type DashStyle =
| 'solid'
| DevExpress.core.RepeatUnion<'dash' | 'dot' | 'longDash', 5>;
export type DiscreteAxisDivisionMode = 'betweenLabels' | 'crossLabels';
/**
* [descr:Font]
Expand Down Expand Up @@ -7189,6 +7191,15 @@ declare module DevExpress.common.grids {
}
}
declare module DevExpress.core {
/**
* @deprecated Attention! This type is for internal purposes only. If you used it previously, please submit a ticket to our {@link https://supportcenter.devexpress.com/ticket/create Support Center}. We will check if there is an alternative solution.
*/
type BuildTuple<
Length extends number,
Result extends unknown[] = []
> = Result['length'] extends Length
? Result
: BuildTuple<Length, [...Result, unknown]>;
/**
* @deprecated Attention! This type is for internal purposes only. If you used it previously, please submit a ticket to our {@link https://supportcenter.devexpress.com/ticket/create Support Center}. We will check if there is an alternative solution.
*/
Expand Down Expand Up @@ -7483,6 +7494,22 @@ declare module DevExpress.core {
* @deprecated Attention! This type is for internal purposes only. If you used it previously, please submit a ticket to our {@link https://supportcenter.devexpress.com/ticket/create Support Center}. We will check if there is an alternative solution.
*/
interface PromiseType<T> extends JQueryPromise<T> {}
/**
* @deprecated Attention! This type is for internal purposes only. If you used it previously, please submit a ticket to our {@link https://supportcenter.devexpress.com/ticket/create Support Center}. We will check if there is an alternative solution.
*/
export type RepeatUnion<
T extends string,
Depth extends number
> = RepeatUnionInternal<T, BuildTuple<Depth>>;
/**
* @deprecated Attention! This type is for internal purposes only. If you used it previously, please submit a ticket to our {@link https://supportcenter.devexpress.com/ticket/create Support Center}. We will check if there is an alternative solution.
*/
type RepeatUnionInternal<
T extends string,
DepthTuple extends unknown[]
> = DepthTuple['length'] extends 0
? never
: T | `${T}${RepeatUnionInternal<T, Tail<DepthTuple>>}`;
/**
* @deprecated Attention! This type is for internal purposes only. If you used it previously, please submit a ticket to our {@link https://supportcenter.devexpress.com/ticket/create Support Center}. We will check if there is an alternative solution.
*/
Expand All @@ -7501,6 +7528,12 @@ declare module DevExpress.core {
| Array<unknown>
| null
| undefined;
/**
* @deprecated Attention! This type is for internal purposes only. If you used it previously, please submit a ticket to our {@link https://supportcenter.devexpress.com/ticket/create Support Center}. We will check if there is an alternative solution.
*/
type Tail<T extends unknown[]> = T extends [unknown, ...infer Rest]
? Rest
: [];

/**
* @deprecated Attention! This type is for internal purposes only. If you used it previously, please submit a ticket to our {@link https://supportcenter.devexpress.com/ticket/create Support Center}. We will check if there is an alternative solution.
Expand Down
Loading