Map: OSM provider - Add route calculation and rendering - #35108
Open
AlisherAmonulloev wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Failed route calculations currently create phantom routes and fire misleading route-added events.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds callback-driven OSM route calculation and OpenLayers vector rendering, including projection-aware bounds and antimeridian handling.
Changes:
- Adds route parsing, rendering, styling, lifecycle handling, and viewport fitting.
- Registers required OpenLayers vector APIs.
- Expands unit tests, mocks, and Storybook coverage.
File summaries
| File | Description |
|---|---|
osmTests.js |
Tests OSM route behavior and lifecycle. |
openLayersMock.js |
Mocks vector layers, features, geometry, and styles. |
openlayers.register.js |
Registers OpenLayers vector dependencies. |
provider.dynamic.osm.ts |
Implements route calculation and provider integration. |
provider.dynamic.osm.test.ts |
Tests route-aware bounds. |
provider.dynamic.osm.route.ts |
Parses routes and normalizes longitudes. |
provider.dynamic.osm.route.test.ts |
Tests route parsing and longitude handling. |
provider.dynamic.osm.openlayers.utils.ts |
Extends OpenLayers interfaces and validation. |
provider.dynamic.osm.openlayers.utils.test.ts |
Updates API validation fixtures. |
provider.dynamic.osm.openlayers.ts |
Renders and disposes vector routes. |
provider.dynamic.osm.engine.ts |
Adds route contracts to the engine API. |
routes.ts |
Provides static Storybook route data. |
OSMMap.stories.tsx |
Demonstrates configurable OSM routes. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Remove-only updates leave auto-adjusted viewports stale, and missing routing configuration can produce duplicate warnings.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 2
- Review effort level: Balanced
AlisherAmonulloev
marked this pull request as ready for review
September 9, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.