Skip to content

remove inlines form react datagrid demos #35128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DuckTieCorpMember wants to merge 3 commits into
base: feature/react-inline-eslint-rules
Choose a base branch
from
Open

remove inlines form react datagrid demos #35128

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adaa2d4
remove inlines form react datagrid demos
DuckTieCorpMember Sep 9, 2026
352c3c1
Update apps/demos/Demos/CardView/FieldTemplate/React/Progress.tsx
DuckTieCorpMember Sep 9, 2026
1dda80c
resolve squad suggestions
DuckTieCorpMember Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apps/demos/Demos/CardView/FieldTemplate/React/Progress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@ interface ProgressProps {
value: number;
}

const progressElementAttributes = { 'aria-label': 'Progress Bar' };
const formatProgressStatus = (_: unknown, value: number) => `${value}%`;
Comment thread
DuckTieCorpMember marked this conversation as resolved.
Outdated

const Progress = ({ value }: ProgressProps) => (
<div className="task__progress">
<ProgressBar
value={value}
elementAttr={{ 'aria-label': 'Progress Bar' }}
statusFormat={(_, value: number) => `${value}%`}
elementAttr={progressElementAttributes}
statusFormat={formatProgressStatus}
/>
</div>
);
Expand Down
6 changes: 4 additions & 2 deletions apps/demos/Demos/CardView/FieldTemplate/ReactJs/Progress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import React from 'react';
import { ProgressBar } from 'devextreme-react/progress-bar';

const progressElementAttributes = { 'aria-label': 'Progress Bar' };
const formatProgressStatus = (_, value) => `${value}%`;
const Progress = ({ value }) => (
<div className="task__progress">
<ProgressBar
value={value}
elementAttr={{ 'aria-label': 'Progress Bar' }}
statusFormat={(_, value) => `${value}%`}
elementAttr={progressElementAttributes}
statusFormat={formatProgressStatus}
/>
</div>
);
Expand Down
6 changes: 3 additions & 3 deletions apps/demos/Demos/DataGrid/AIAssistant/React/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useCallback, useRef } from 'react';
import React, { useCallback, useMemo, useRef } from 'react';

import DataGrid, {
Column,
Expand Down Expand Up @@ -76,7 +76,7 @@ export default function App() {
}]);
}, []);

const chatOptions: ChatTypes.Properties = {
const chatOptions = useMemo<ChatTypes.Properties>(() => ({
onInitialized: onChatInitialized,
user: {
id: 'user',
Expand All @@ -85,7 +85,7 @@ export default function App() {
...suggestions,
onItemClick: onSuggestionItemClick,
},
};
}), [onChatInitialized, onSuggestionItemClick]);

return (
<DataGrid
Expand Down
25 changes: 14 additions & 11 deletions apps/demos/Demos/DataGrid/AIAssistant/ReactJs/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useCallback, useRef } from 'react';
import React, { useCallback, useMemo, useRef } from 'react';
import DataGrid, {
Column,
Paging,
Expand Down Expand Up @@ -69,16 +69,19 @@ export default function App() {
},
]);
}, []);
const chatOptions = {
onInitialized: onChatInitialized,
user: {
id: 'user',
},
suggestions: {
...suggestions,
onItemClick: onSuggestionItemClick,
},
};
const chatOptions = useMemo(
() => ({
onInitialized: onChatInitialized,
user: {
id: 'user',
},
suggestions: {
...suggestions,
onItemClick: onSuggestionItemClick,
},
}),
[onChatInitialized, onSuggestionItemClick],
);
return (
<DataGrid
id="gridContainer"
Expand Down
22 changes: 13 additions & 9 deletions apps/demos/Demos/DataGrid/AIColumns/React/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,17 @@ export default function App() {
setCurrentVehicle(null);
}, []);

const renderTrademark = useCallback((cellData: DataGridTypes.ColumnCellTemplateData) => (
<Trademark
vehicle={cellData.data}
onShowInfo={showInfo}
/>
), [showInfo]);

const renderLicenseInfo = useCallback(() => (
<LicenseInfo vehicle={currentVehicle} />
), [currentVehicle]);

return (
<>
<DataGrid
Expand All @@ -55,12 +66,7 @@ export default function App() {
caption="Trademark"
width={200}
dataField="TrademarkName"
cellRender={(cellData) =>
<Trademark
vehicle={cellData.data}
onShowInfo={showInfo}
/>
}
cellRender={renderTrademark}
/>
<Column
dataField="Price"
Expand Down Expand Up @@ -110,9 +116,7 @@ export default function App() {
hideOnOutsideClick={true}
title="Image Info"
onHiding={hideInfo}
contentRender={() =>
<LicenseInfo vehicle={currentVehicle} />
}
contentRender={renderLicenseInfo}
>
<Position
at="center"
Expand Down
4 changes: 3 additions & 1 deletion apps/demos/Demos/DataGrid/AIColumns/React/Trademark.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ export default function Trademark({ vehicle, onShowInfo }: TrademarkProps) {
}
}, [onShowInfo, vehicle]);

const onClick = useCallback(() => onShowInfo(vehicle), [onShowInfo, vehicle]);

return (
<div className="trademark__wrapper">
<div className="trademark__img-wrapper">
Expand All @@ -23,7 +25,7 @@ export default function Trademark({ vehicle, onShowInfo }: TrademarkProps) {
src={`../../../../images/vehicles/image_${ID}.png`}
alt={`${TrademarkName} ${Name}`}
tabIndex={0}
onClick={() => onShowInfo(vehicle)}
onClick={onClick}
role="button"
onKeyDown={onKeyDown}
aria-haspopup="dialog"
Expand Down
22 changes: 15 additions & 7 deletions apps/demos/Demos/DataGrid/AIColumns/ReactJs/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,19 @@ export default function App() {
const hideInfo = useCallback(() => {
setCurrentVehicle(null);
}, []);
const renderTrademark = useCallback(
(cellData) => (
<Trademark
vehicle={cellData.data}
onShowInfo={showInfo}
/>
),
[showInfo],
);
const renderLicenseInfo = useCallback(
() => <LicenseInfo vehicle={currentVehicle} />,
[currentVehicle],
);
return (
<>
<DataGrid
Expand All @@ -44,12 +57,7 @@ export default function App() {
caption="Trademark"
width={200}
dataField="TrademarkName"
cellRender={(cellData) => (
<Trademark
vehicle={cellData.data}
onShowInfo={showInfo}
/>
)}
cellRender={renderTrademark}
/>
<Column
dataField="Price"
Expand Down Expand Up @@ -99,7 +107,7 @@ export default function App() {
hideOnOutsideClick={true}
title="Image Info"
onHiding={hideInfo}
contentRender={() => <LicenseInfo vehicle={currentVehicle} />}
contentRender={renderLicenseInfo}
>
<Position
at="center"
Expand Down
3 changes: 2 additions & 1 deletion apps/demos/Demos/DataGrid/AIColumns/ReactJs/Trademark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default function Trademark({ vehicle, onShowInfo }) {
},
[onShowInfo, vehicle],
);
const onClick = useCallback(() => onShowInfo(vehicle), [onShowInfo, vehicle]);
return (
<div className="trademark__wrapper">
<div className="trademark__img-wrapper">
Expand All @@ -18,7 +19,7 @@ export default function Trademark({ vehicle, onShowInfo }) {
src={`../../../../images/vehicles/image_${ID}.png`}
alt={`${TrademarkName} ${Name}`}
tabIndex={0}
onClick={() => onShowInfo(vehicle)}
onClick={onClick}
role="button"
onKeyDown={onKeyDown}
aria-haspopup="dialog"
Expand Down
37 changes: 21 additions & 16 deletions apps/demos/Demos/DataGrid/CustomEditors/React/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, { useCallback } from 'react';

import DataGrid, {
Paging,
Expand Down Expand Up @@ -73,36 +73,41 @@ function calculateFilterExpression(

const onRowInserted = (e: DataGridTypes.RowInsertedEvent) => e.component.navigateToRow(e.key);

const statusEditorRender = (cell: DataGridTypes.ColumnEditCellTemplateData) => {
const onValueChanged = (e: SelectBoxTypes.ValueChangedEvent) => cell.setValue(e.value);
const statusEditorRender = (cell: DataGridTypes.ColumnEditCellTemplateData) => <StatusEditor cell={cell} />;

const itemRender = (data: { id: number, name: string } | null) => {
if (data) {
const imageSource = `images/icons/status-${data.id}.svg`;
const statusItemRender = (data: { id: number, name: string } | null) => {
if (data) {
const imageSource = `images/icons/status-${data.id}.svg`;

return (
<div>
<img src={imageSource} className="status-icon middle"></img>
<span className="middle">{data.name}</span>
</div>
);
}
return (
<div>
<img src={imageSource} className="status-icon middle"></img>
<span className="middle">{data.name}</span>
</div>
);
}

return <span>(All)</span>;
};
return <span>(All)</span>;
};

const StatusEditor = ({ cell }: { cell: DataGridTypes.ColumnEditCellTemplateData }) => {
const lookupDataSource = cell.column.lookup?.dataSource;
const dataSource = typeof lookupDataSource === 'function'
? lookupDataSource({ data: cell.data, key: cell.row.key })
: lookupDataSource;
const onValueChanged = useCallback((e: SelectBoxTypes.ValueChangedEvent) => {
cell.setValue(e.value);
}, [cell]);

return (
<SelectBox
defaultValue={cell.value}
dataSource={dataSource}
displayExpr="name"
valueExpr="id"
onValueChanged={onValueChanged}
inputAttr={statusLabel}
itemRender={itemRender} />
itemRender={statusItemRender} />
);
};

Expand Down
64 changes: 31 additions & 33 deletions apps/demos/Demos/DataGrid/CustomEditors/React/EmployeeDropDownBoxComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ import DropDownBox, { type DropDownBoxTypes } from 'devextreme-react/drop-down-b

const dropDownOptions = { width: 500 };
const ownerLabel = { 'aria-label': 'Owner' };
const clearContextMenu = (event: DataGridTypes.ContextMenuPreparingEvent) => {
event.items = [];
};

const EmployeeDropDownBoxComponent = (props: DataGridTypes.ColumnCellTemplateData) => {
Comment thread
DuckTieCorpMember marked this conversation as resolved.
Outdated
const { data: { value: dataValue } } = props;
Expand All @@ -24,41 +27,36 @@ const EmployeeDropDownBoxComponent = (props: DataGridTypes.ColumnCellTemplateDat
}
}, []);

const contentRender = useCallback(() => {
const onContextMenuPreparing = (event: DataGridTypes.ContextMenuPreparingEvent) => {
event.items = [];
};
const onSelectionChanged = (args: DataGridTypes.SelectionChangedEvent) => {
setSelectedRowKeys(args.selectedRowKeys);
setDropDownOpened(false);
const onSelectionChanged = useCallback((args: DataGridTypes.SelectionChangedEvent) => {
setSelectedRowKeys(args.selectedRowKeys);
setDropDownOpened(false);

props.data.setValue(args.selectedRowKeys[0]);
};
props.data.setValue(args.selectedRowKeys[0]);
}, [props.data]);

return (
<DataGrid
dataSource={props.data.column.lookup.dataSource}
remoteOperations={true}
height={250}
selectedRowKeys={selectedRowKeys}
hoverStateEnabled={true}
onContextMenuPreparing={onContextMenuPreparing}
onSelectionChanged={onSelectionChanged}
focusedRowEnabled={true}
defaultFocusedRowKey={selectedRowKeys[0]}
>
<Column dataField="FullName" />
<Column dataField="Title" />
<Column dataField="Department" />
<Paging
enabled={true}
defaultPageSize={10}
/>
<Scrolling mode="virtual" />
<Selection mode="single" />
</DataGrid>
);
}, [props.data, selectedRowKeys]);
const contentRender = useCallback(() => (
<DataGrid
dataSource={props.data.column.lookup.dataSource}
remoteOperations={true}
height={250}
selectedRowKeys={selectedRowKeys}
hoverStateEnabled={true}
onContextMenuPreparing={clearContextMenu}
onSelectionChanged={onSelectionChanged}
focusedRowEnabled={true}
defaultFocusedRowKey={selectedRowKeys[0]}
>
<Column dataField="FullName" />
<Column dataField="Title" />
<Column dataField="Department" />
<Paging
enabled={true}
defaultPageSize={10}
/>
<Scrolling mode="virtual" />
<Selection mode="single" />
</DataGrid>
), [props.data, onSelectionChanged, selectedRowKeys]);

return (
<DropDownBox
Expand Down
Loading
Loading