T1335911 - DataGrid — Incorrect column resize separator position when resizing a column fixed to the right if another column is behind it - #35364
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates sticky-column separator positioning for DataGrid and TreeList column resizing.
Changes:
- Anchors separators to the next right-pinned column when applicable.
- Adds Jest coverage for sticky resizer offset behavior.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts | Updated as part of this pull request. |
| packages/devextreme/js/__internal/grids/grid_core/sticky_columns/__tests__/m_sticky_columns.columns_resizer.test.ts | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| && GridCoreStickyColumnsDom.isFixedCellPinnedToRight($nextCell, $container, addWidgetPrefix); | ||
|
|
||
| if (isNextCellPinnedToRight) { | ||
| return $nextCell.offset()?.left ?? 0; |
There was a problem hiding this comment.
The RTL mode is not taken into account. Also, just in case, please check the resizing behavior with the following functionality:
- columnResizingMode: 'widget'
- Band columns
- Adaptability
There was a problem hiding this comment.
checked RTL, widget mode, band columns and adaptivity in the browser - the separator tracks the column edge in each, so RTL needs no special handling here
| return $cell.offset()?.left ?? 0; | ||
| } | ||
|
|
||
| const $nextCell = $cell.next(); |
There was a problem hiding this comment.
It would be better to get the next column by index using either _resizingInfo.nextColumnIndex or _getNextColumnIndex(currentColumnIndex).
What
The column resize separator now lands at the correct position when you resize a column fixed to the right in DataGrid and TreeList with sticky columns, instead of appearing outside the grid
How
In the sticky columns resizer, when the resized column is immediately followed by a column pinned to the right, the separator is anchored to that pinned column's left edge