Skip to content

Grids - Remove 'm_' prefixes - AI Column, Toast & misc - #35432

Merged
anna-shakhova merged 5 commits into
DevExpress:mainfrom
Tucchhaa:remove_m_prefix_26_2
Oct 1, 2026
Merged

anna-shakhova merged 5 commits into
DevExpress:mainfrom
Tucchhaa:remove_m_prefix_26_2

Conversation

@Tucchhaa

Copy link
Copy Markdown
Contributor

No description provided.

@Tucchhaa Tucchhaa self-assigned this Sep 30, 2026
@Tucchhaa Tucchhaa added the 26_2 label Sep 30, 2026
@Tucchhaa
Tucchhaa force-pushed the remove_m_prefix_26_2 branch from c2e7446 to 4bb275f Compare September 30, 2026 17:33
Eldar Iusupzhanov added 3 commits October 1, 2026 11:07
@Tucchhaa
Tucchhaa force-pushed the remove_m_prefix_26_2 branch from 4bb275f to 3a227fd Compare October 1, 2026 03:13
@Tucchhaa Tucchhaa changed the title Grids - Remove 'm_' prefixes Grids - Remove 'm_' prefixes - AI Column, Toast & misc Oct 1, 2026
@Tucchhaa
Tucchhaa requested a balanced review from Copilot October 1, 2026 03:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The AI Column refactor leaves a duplicate, unused private implementation that should be removed.

Review effort: Balanced
Findings: None

What changed in this PR

Removes legacy m_ prefixes from internal Grid modules and updates references while tightening TypeScript typing.

Changes:

  • Renames AI Column, Toast, filter-sync, focus, and keyboard-navigation modules.
  • Updates imports and Grid controller/view registrations.
  • Adds template typings and lint/type refinements.
File Description
tree_list/​module_not_extended/​toast.ts Updates Toast imports.
grid_core/​views/​types.ts Adds column-template types.
grid_core/​views/​m_columns_view.ts Types template processing.
grid_core/​toast/​toast_view.ts Renames Toast view module.
grid_core/​toast/​toast_controller.ts Updates Toast view import.
grid_core/​state_storing/​state_storing_controller.ts Updates filter-sync import.
grid_core/​master_detail/​master_detail.integration.test.ts Adds lint suppressions.
grid_core/​m_types.ts Updates renamed module registrations.
grid_core/​keyboard_navigation/​m_headers_keyboard_navigation.ts Updates dispatcher import.
grid_core/​keyboard_navigation/​m_column_keyboard_navigation_core.ts Updates dispatcher type import.
grid_core/​keyboard_navigation/​column_focus_dispatcher.ts Renames dispatcher module.
grid_core/​focus/​m_focus.ts Updates focus utility import and typing.
grid_core/​focus/​m_focus_utils.ts Removes prefixed utility module.
grid_core/​focus/​focus_utils.ts Adds typed focus utility module.
grid_core/​filter_sync/​filter_sync.ts Renames filter-sync controller module.
grid_core/​filter_sync/​filter_sync_module.ts Updates controller import.
grid_core/​filter_sync/​extenders/​filter_sync_data_controller.ts Updates filter-sync type import.
grid_core/​error_handling/​error_handling_view_controller.ts Updates Toast controller import.
grid_core/​column_headers/​m_column_headers.ts Types processed templates.
grid_core/​ai_column/​views/​ai_prompt_editor_view.ts Updates AI controller import and return type.
grid_core/​ai_column/​views/​ai_prompt_editor_view.test.ts Updates renamed view import.
grid_core/​ai_column/​views/​ai_column_view.ts Updates imports and template typing.
grid_core/​ai_column/​index.ts Re-exports renamed modules.
grid_core/​ai_column/​controllers/​ai_prompt_editor_view_controller.ts Updates view import.
grid_core/​ai_column/​controllers/​ai_column_integration_controller.ts Updates cache-controller import.
grid_core/​ai_column/​controllers/​ai_column_controller.ts Refactors default-cell handling and imports.
grid_core/​ai_column/​controllers/​ai_column_cache_controller.ts Renames cache-controller module.
data_grid/​module_not_extended/​toast.ts Updates Toast imports.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Tucchhaa
Tucchhaa marked this pull request as ready for review October 1, 2026 03:27
@Tucchhaa
Tucchhaa requested a review from a team as a code owner October 1, 2026 03:27
Copilot AI balanced review requested due to automatic review settings October 1, 2026 03:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Renamed module references are consistently updated and the accompanying typing changes preserve existing behavior.

Review effort: Balanced
Findings: None

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason this file is recognized as new one, not renamed
perhaps this is because of added types - we can try to move it outside file

Copilot AI balanced review requested due to automatic review settings October 1, 2026 06:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Renamed module references are consistently updated and the accompanying typing changes preserve existing behavior.

Review effort: Balanced
Findings: None

@anna-shakhova
anna-shakhova added this pull request to the merge queue Oct 1, 2026
Merged via the queue into DevExpress:main with commit 6bc6c39 Oct 1, 2026
149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants