Grids - Remove 'm_' prefixes - AI Column, Toast & misc - #35432
Merged
Merged
Conversation
Tucchhaa
force-pushed
the
remove_m_prefix_26_2
branch
from
September 30, 2026 17:33
c2e7446 to
4bb275f
Compare
Tucchhaa
force-pushed
the
remove_m_prefix_26_2
branch
from
October 1, 2026 03:13
4bb275f to
3a227fd
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The AI Column refactor leaves a duplicate, unused private implementation that should be removed.
Review effort: Balanced
Findings: None
What changed in this PR
Removes legacy m_ prefixes from internal Grid modules and updates references while tightening TypeScript typing.
Changes:
- Renames AI Column, Toast, filter-sync, focus, and keyboard-navigation modules.
- Updates imports and Grid controller/view registrations.
- Adds template typings and lint/type refinements.
| File | Description |
|---|---|
tree_list/module_not_extended/toast.ts |
Updates Toast imports. |
grid_core/views/types.ts |
Adds column-template types. |
grid_core/views/m_columns_view.ts |
Types template processing. |
grid_core/toast/toast_view.ts |
Renames Toast view module. |
grid_core/toast/toast_controller.ts |
Updates Toast view import. |
grid_core/state_storing/state_storing_controller.ts |
Updates filter-sync import. |
grid_core/master_detail/master_detail.integration.test.ts |
Adds lint suppressions. |
grid_core/m_types.ts |
Updates renamed module registrations. |
grid_core/keyboard_navigation/m_headers_keyboard_navigation.ts |
Updates dispatcher import. |
grid_core/keyboard_navigation/m_column_keyboard_navigation_core.ts |
Updates dispatcher type import. |
grid_core/keyboard_navigation/column_focus_dispatcher.ts |
Renames dispatcher module. |
grid_core/focus/m_focus.ts |
Updates focus utility import and typing. |
grid_core/focus/m_focus_utils.ts |
Removes prefixed utility module. |
grid_core/focus/focus_utils.ts |
Adds typed focus utility module. |
grid_core/filter_sync/filter_sync.ts |
Renames filter-sync controller module. |
grid_core/filter_sync/filter_sync_module.ts |
Updates controller import. |
grid_core/filter_sync/extenders/filter_sync_data_controller.ts |
Updates filter-sync type import. |
grid_core/error_handling/error_handling_view_controller.ts |
Updates Toast controller import. |
grid_core/column_headers/m_column_headers.ts |
Types processed templates. |
grid_core/ai_column/views/ai_prompt_editor_view.ts |
Updates AI controller import and return type. |
grid_core/ai_column/views/ai_prompt_editor_view.test.ts |
Updates renamed view import. |
grid_core/ai_column/views/ai_column_view.ts |
Updates imports and template typing. |
grid_core/ai_column/index.ts |
Re-exports renamed modules. |
grid_core/ai_column/controllers/ai_prompt_editor_view_controller.ts |
Updates view import. |
grid_core/ai_column/controllers/ai_column_integration_controller.ts |
Updates cache-controller import. |
grid_core/ai_column/controllers/ai_column_controller.ts |
Refactors default-cell handling and imports. |
grid_core/ai_column/controllers/ai_column_cache_controller.ts |
Renames cache-controller module. |
data_grid/module_not_extended/toast.ts |
Updates Toast imports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tucchhaa
marked this pull request as ready for review
October 1, 2026 03:27
Contributor
There was a problem hiding this comment.
for some reason this file is recognized as new one, not renamed
perhaps this is because of added types - we can try to move it outside file
anna-shakhova
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.