Grids: type columnsController file-local members and public API

packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/grouping.ts

@@ -29,7 +29,8 @@ export const groupingCommand = defineGridCommand({
   schema: groupingCommandSchema,
   execute: (component, { success, failure }) => (args): Promise<CommandResult> => {
     const columnsController = component.getController('columns');
-    const column: Column | undefined = columnsController.columnOption(args.dataField);
+    const column = columnsController.columnOption(args.dataField);
+    // @ts-expect-error GridCore and DataGrid column types are not aligned
     const defaultMessage = getGroupingDefaultMessage(args, column);
 
     if (!column || column.allowGrouping === false) {

packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/summary.ts

@@ -46,7 +46,7 @@ const SUMMARY_TYPE_LABELS: Record<SummaryItem['summaryType'], string> = {
 const buildItemLabel = (
   item: SummaryItem,
   location: 'total' | 'group',
-  columnsController: { columnOption: (id: string) => Column | undefined },
+  columnsController: { columnOption: (id: string) => Pick<Column, 'caption'> | undefined },
 ): string => {
   const column = columnsController.columnOption(item.column);
   const caption = column?.caption ?? item.column;
@@ -57,7 +57,7 @@ const buildItemLabel = (
 const buildDefaultMessage = (
   totalItems: SummaryItem[],
   groupItems: SummaryItem[],
-  columnsController: { columnOption: (id: string) => Column | undefined },
+  columnsController: { columnOption: (id: string) => Pick<Column, 'caption'> | undefined },
 ): string => {
   if (totalItems.length === 0 && groupItems.length === 0) {
     return 'Display data summaries.';

packages/devextreme/js/__internal/grids/data_grid/focus/m_focus.ts

@@ -57,6 +57,7 @@ const data = (Base: DataControllerBase) => class FocusDataControllerExtender ext
 
     if (focusedRow) {
       for (let i = 0; i < path.length; ++i) {
+        // @ts-expect-error compileGetter also accepts function selectors at runtime
         const getter = compileGetter(groups[i] && groups[i].selector);
 
         // @ts-expect-error

packages/devextreme/js/__internal/grids/data_grid/grouping/extenders/grouping_columns_controller.ts

@@ -9,7 +9,6 @@ export const groupingColumnsControllerExtender = (
   public _getExpandColumnOptions() {
     const options = super._getExpandColumnOptions();
 
-    // @ts-expect-error
     options.cellTemplate = gridCore.getExpandCellTemplate();
 
     return options;

packages/devextreme/js/__internal/grids/data_grid/keyboard_navigation/m_group_panel_keyboard_navigation.ts

@@ -15,7 +15,7 @@ import { CLASSES as GROUPING_CLASSES } from '../grouping/const';
 import { ColumnKeyboardNavigationMixin } from './m_column_keyboard_navigation_mixin';
 
 export class GroupPanelKeyboardNavigationController extends ColumnKeyboardNavigationMixin(ColumnKeyboardNavigationController) {
-  private isNeedToHiddenFocusAfterClick = false;
+  private isNeedToHiddenFocusAfterClick: boolean | undefined = false;
 
   private groupItemClickHandlerContext!: (event: any) => void;
 

packages/devextreme/js/__internal/grids/data_grid/summary/extenders/summary_data_controller.ts

@@ -66,6 +66,7 @@ export const summaryDataControllerExtender = (
       const columnName = groupItem.showInColumn ?? groupItem.column;
       const column = this._columnsController.columnOption(columnName);
 
+      // @ts-expect-error GridCore and DataGrid column types are not aligned
       if (groupItem.showInGroupFooter && isDataColumn(column)) {
         return true;
       }

packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts

@@ -332,7 +332,7 @@ export class AdaptiveColumnsController extends modules.ViewController {
           containerWidth,
         });
       } else {
-        return parseFloat(widthOption);
+        return parseFloat(String(widthOption));
       }
     } else {
       const columnAutoWidth = this.option('columnAutoWidth');
@@ -356,11 +356,12 @@ export class AdaptiveColumnsController extends modules.ViewController {
     const bestFitWidth = this._columnsController.columnOption(columnId, 'bestFitWidth');
 
     if (widthOption && widthOption !== 'auto' && !this._isPercentWidth(widthOption)) {
-      return parseFloat(widthOption);
+      return parseFloat(String(widthOption));
     }
 
     const colWidth = this._calculateColumnWidth(column, containerWidth, contentColumns, columnsCanFit);
 
+    // @ts-expect-error bestFitWidth can be absent; the comparison then returns false
     return colWidth < bestFitWidth ? null : colWidth;
   }
 

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/sorting.ts

@@ -33,7 +33,7 @@ export const sortingCommand = defineGridCommand({
     const column: Column | undefined = columnsController.columnOption(args.dataField);
     const defaultMessage = getSortingDefaultMessage(args, column);
 
-    if (!column || !columnsController.allowColumnSorting(column)) {
+    if (!column || !columnsController.allowColumnSorting(column) || column.index === undefined) {
       return Promise.resolve(failure(defaultMessage));
     }
 

packages/devextreme/js/__internal/grids/grid_core/ai_column/controllers/ai_column_controller.ts

@@ -80,6 +80,7 @@ export class AIColumnController extends Controller {
       ...getAICommandColumnDefaultOptions(),
       calculateCellValue(data: RawItemData) {
         const key = dataSourceController.keyOf(data);
+        // @ts-expect-error the column name is initialized before calculateCellValue is called
         const cellValue = aiColumnIntegrationController.getAIColumnText(this.name, key);
         const defaultValue = getDefaultCellValue(this, cellValue);
 

packages/devextreme/js/__internal/grids/grid_core/columns_controller/__tests__/columns_controller.integration.test.ts

@@ -51,6 +51,30 @@ describe('getFilteringColumns', () => {
   });
 });
 
+describe('column fixing enablement', () => {
+  beforeEach(beforeTest);
+  afterEach(afterTest);
+
+  it.each([
+    { enabled: undefined, fixed: false, expected: undefined },
+    { enabled: undefined, fixed: true, expected: true },
+    { enabled: false, fixed: false, expected: false },
+    { enabled: false, fixed: true, expected: true },
+    { enabled: true, fixed: false, expected: true },
+    { enabled: true, fixed: true, expected: true },
+  ])('preserves enabled=$enabled when fixed=$fixed', async ({ enabled, fixed, expected }) => {
+    const { instance } = await createDataGrid({
+      dataSource: [{ id: 1 }],
+      columns: [{ dataField: 'id', fixed }],
+    });
+    instance.option('columnFixing.enabled', enabled);
+
+    const result = instance.getController('columns')._isColumnFixing();
+
+    expect(result).toBe(expected);
+  });
+});
+
 describe('Bugs', () => {
   beforeEach(() => {
     beforeTest();