Fix Demos: Use public API to detect the current theme - #35454
Merged
16adianay merged 6 commits intoOct 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes consistently use the public theme API, with no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Scheduler and DataGrid demos to detect the current theme through DevExtreme’s public API.
Changes:
- Replaces Scheduler’s DOM-based theme detection with
themes.current(). - Replaces DataGrid’s internal
isGenerichelper with a theme-name prefix check.
| File | Description |
|---|---|
| apps/demos/Demos/Scheduler/Templates/Vue/App.vue | Uses public theme detection for editor styling. |
| apps/demos/Demos/Scheduler/Templates/ReactJs/App.js | Uses public theme detection for editor styling. |
| apps/demos/Demos/Scheduler/Templates/React/App.tsx | Uses public theme detection for editor styling. |
| apps/demos/Demos/Scheduler/Templates/jQuery/index.js | Uses the public global theme API. |
| apps/demos/Demos/Scheduler/Templates/Angular/app/app.component.ts | Uses public theme detection for editor styling. |
| apps/demos/Demos/DataGrid/MultipleRecordSelectionModes/Vue/App.vue | Replaces the internal helper for checkbox defaults. |
| apps/demos/Demos/DataGrid/MultipleRecordSelectionModes/ReactJs/App.js | Replaces the internal helper for checkbox defaults. |
| apps/demos/Demos/DataGrid/MultipleRecordSelectionModes/React/App.tsx | Replaces the internal helper for checkbox defaults. |
| apps/demos/Demos/DataGrid/MultipleRecordSelectionModes/Angular/app/app.component.ts | Replaces the internal helper for checkbox defaults. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sjbur
previously approved these changes
Oct 2, 2026
aleksei-semikozov
previously approved these changes
Oct 2, 2026
bit-byte0
reviewed
Oct 2, 2026
bit-byte0
previously approved these changes
Oct 2, 2026
16adianay
dismissed stale reviews from aleksei-semikozov and sjbur
via
October 2, 2026 13:27
7ac960f
bit-byte0
previously approved these changes
Oct 2, 2026
bit-byte0
approved these changes
Oct 2, 2026
16adianay
enabled auto-merge
October 2, 2026 14:54
sjbur
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.