Repository navigation
Grids: remove m_ prefix from files in grid_core columns_controller module - #35461
Merged
bit-byte0 merged 3 commits intoOct 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The rename is consistently applied and no references to the removed module names remain.
Review effort: Balanced
Findings: None
What changed in this PR
Renames the GridCore columns controller, utility, and test files to remove the legacy m_ prefix while preserving behavior.
Changes:
- Renamed controller and utility modules.
- Updated all affected imports and controller type references.
- Renamed the associated Jest test.
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/columnsResizingReorderingModule.tests.js |
Updates controller import. |
packages/devextreme/js/__internal/grids/tree_list/columns_controller.ts |
Updates controller import. |
packages/devextreme/js/__internal/grids/new/grid_core/utils/parse_value/parse_value.ts |
Updates utility import. |
packages/devextreme/js/__internal/grids/new/grid_core/column_chooser/controller.ts |
Updates utility import. |
packages/devextreme/js/__internal/grids/grid_core/virtual_columns/m_virtual_columns.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/views/utils.ts |
Updates utility import. |
packages/devextreme/js/__internal/grids/grid_core/views/m_grid_view.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/views/m_columns_view.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/validating/m_validating.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/sticky_columns/utils.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/state_storing/state_storing_controller_core.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/state_storing/extenders/state_storing_columns_controller.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/selection/m_selection.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/master_detail/m_master_detail.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/m_types.ts |
Updates controller type mapping. |
packages/devextreme/js/__internal/grids/grid_core/header_filter/m_header_filter.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/focus/m_focus.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/filter_sync/filter_sync.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/filter_row/m_filter_row.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/filter_panel/m_filter_panel.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/filter_builder/m_filter_builder.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/error_handling/error_handling_view_controller.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/editor_factory/m_editor_factory.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/row_values.ts |
Updates utility import. |
packages/devextreme/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/columns_controller/user_state_applier.ts |
Updates local utility import. |
packages/devextreme/js/__internal/grids/grid_core/columns_controller/columns_controller.ts |
Renames the controller module and updates its utility import. |
packages/devextreme/js/__internal/grids/grid_core/columns_controller/columns_controller.test.ts |
Renames the controller test. |
packages/devextreme/js/__internal/grids/grid_core/columns_controller/columns_controller_utils.ts |
Renames utilities and updates the controller type import. |
packages/devextreme/js/__internal/grids/grid_core/columns_controller/__tests__/columns_controller_utils.user_state_column.test.ts |
Updates utility import. |
packages/devextreme/js/__internal/grids/grid_core/columns_controller/__tests__/columns_controller_utils.test.ts |
Updates controller and utility imports. |
packages/devextreme/js/__internal/grids/grid_core/columns_controller/__tests__/columns_controller_utils.column_state_fields.test.ts |
Updates utility import. |
packages/devextreme/js/__internal/grids/grid_core/columns_controller/__tests__/column_has_value.test.ts |
Updates utility import. |
packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/ai_column/views/ai_prompt_editor_view.ts |
Updates controller and utility imports. |
packages/devextreme/js/__internal/grids/grid_core/ai_column/controllers/ai_column_integration_controller.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/ai_column/controllers/ai_column_controller.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_integration_controller.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_columns_controller.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/data_grid/summary/m_summary.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/data_grid/grouping/extenders/grouping_columns_controller.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/data_grid/export/m_export.ts |
Updates controller type import. |
packages/devextreme/js/__internal/grids/data_grid/columns_controller.ts |
Updates controller module import. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
anna-shakhova
approved these changes
Oct 5, 2026
Contributor
There was a problem hiding this comment.
lets move into tests folder
anna-shakhova
left a comment
anna-shakhova
left a comment
Contributor
There was a problem hiding this comment.
fix PR name, please
anna-shakhova
requested changes
Oct 5, 2026
…troller-rename-main
bit-byte0
changed the title
bit-byte0
changed the title
anna-shakhova
approved these changes
Oct 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
m_prefix from columns controller filesHow
Rename the controller, utils, and controller test together and update all import paths