Repository navigation
FilterBuilder: fix errors and improve typing - #35477
Merged
EugeniyKiyashko merged 8 commits intoOct 6, 2026
Merged
EugeniyKiyashko merged 8 commits into
EugeniyKiyashko merged 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The shared type changes and integration suppressions need compiler validation and final human review before approval.
Review effort: Balanced
Findings: None
What changed in this PR
This PR strengthens FilterBuilder’s internal typing and adapts its shared utilities’ grid integration points.
Changes:
- Adds explicit types for filter expressions, fields, operations, editors, and events.
- Refactors utility and widget code while preserving existing behavior.
- Documents remaining type mismatches with targeted suppressions.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/new/grid_core/filtering/utils.ts | Annotates unknown filter input mismatches. |
| packages/devextreme/js/__internal/grids/new/grid_core/filtering/legacy_filter_custom_operations.ts | Annotates expression-array type mismatches. |
| packages/devextreme/js/__internal/grids/new/grid_core/filtering/header_filter/view_controller.ts | Annotates filter-removal input mismatches. |
| packages/devextreme/js/__internal/grids/new/card_view/header_panel/header_panel.tsx | Removes a boolean cast and annotates the input mismatch. |
| packages/devextreme/js/__internal/grids/grid_core/filter_sync/utils.ts | Annotates optional filter input mismatches. |
| packages/devextreme/js/__internal/grids/grid_core/filter_sync/m_filter_custom_operations.ts | Annotates expression-array type mismatches. |
| packages/devextreme/js/__internal/grids/grid_core/filter_sync/extenders/filter_sync_column_headers_view.ts | Annotates an optional filter input mismatch. |
| packages/devextreme/js/__internal/grids/grid_core/filter_builder/m_filter_builder.ts | Annotates grid and FilterBuilder type incompatibilities. |
| packages/devextreme/js/__internal/filter_builder/m_utils.ts | Types and refactors shared filtering utilities. |
| packages/devextreme/js/__internal/filter_builder/m_filter_operations_dictionary.ts | Types operation dictionaries and lookups. |
| packages/devextreme/js/__internal/filter_builder/m_filter_builder.ts | Types widget options, state, menus, and handlers. |
| packages/devextreme/js/__internal/filter_builder/m_between.ts | Types range values and editor-factory contracts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
EugeniyKiyashko
force-pushed
the
typescript/filter_builder/typing_5275
branch
from
October 5, 2026 21:20
b4e4e0d to
d8770d4
Compare
…perations_dictionary, m_utils (DevExpress#5275)
…ations guard and copy (DevExpress#5275)
…e and keep null operations (DevExpress#5275)
EugeniyKiyashko
force-pushed
the
typescript/filter_builder/typing_5275
branch
from
October 6, 2026 09:23
eaca9cf to
7e9458d
Compare
anna-shakhova
approved these changes
Oct 6, 2026
EugeniyKiyashko
added a commit
to EugeniyKiyashko/DevExtreme
that referenced
this pull request
Oct 6, 2026
The filter builder was typed in DevExpress#35477 after the hub typing was cut: its action config is the merged object that the action options do not accept. Only a directive is added, the emitted code is unchanged.
EugeniyKiyashko
added a commit
to EugeniyKiyashko/DevExtreme
that referenced
this pull request
Oct 6, 2026
The filter builder was typed in DevExpress#35477 after the hub typing was cut: its action config is the merged object that the action options do not accept. Only a directive is added, the emitted code is unchanged.
EugeniyKiyashko
added a commit
to EugeniyKiyashko/DevExtreme
that referenced
this pull request
Oct 6, 2026
The filter builder was typed in DevExpress#35477 after the hub typing was cut: its action config is the merged object that the action options do not accept. Only a directive is added, the emitted code is unchanged.
EugeniyKiyashko
added a commit
to EugeniyKiyashko/DevExtreme
that referenced
this pull request
Oct 6, 2026
The filter builder was typed in DevExpress#35477 after the hub typing was cut: its action config is the merged object that the action options do not accept. Only a directive is added, the emitted code is unchanged.
EugeniyKiyashko
added a commit
to EugeniyKiyashko/DevExtreme
that referenced
this pull request
Oct 6, 2026
The filter builder was typed in DevExpress#35477 after the hub typing was cut: its action config is the merged object that the action options do not accept. Only a directive is added, the emitted code is unchanged.
EugeniyKiyashko
added a commit
to EugeniyKiyashko/DevExtreme
that referenced
this pull request
Oct 7, 2026
The filter builder was typed in DevExpress#35477 after the hub typing was cut: its action config is the merged object that the action options do not accept. Only a directive is added, the emitted code is unchanged.
EugeniyKiyashko
added a commit
to EugeniyKiyashko/DevExtreme
that referenced
this pull request
Oct 7, 2026
The filter builder was typed in DevExpress#35477 after the hub typing was cut: its action config is the merged object that the action options do not accept. Only a directive is added, the emitted code is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.