Repository navigation
Draggable, Sortable: fix errors and improve typing - #35481
Merged
EugeniyKiyashko merged 3 commits intoOct 6, 2026
Merged
EugeniyKiyashko merged 3 commits into
EugeniyKiyashko merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Event forwarding is malformed for sortable-to-draggable removals, and several callback payloads are incorrectly typed as never.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Improves internal typing for Draggable and Sortable while preserving their drag-and-drop behavior.
Changes:
- Adds typed event, option, geometry, and helper interfaces.
- Replaces broad casts and dynamic calls with typed implementations.
- Uses typed internal utility imports.
| File | Description |
|---|---|
packages/devextreme/js/__internal/m_draggable.ts |
Adds generic properties and typed drag infrastructure. |
packages/devextreme/js/__internal/m_sortable.ts |
Adds concrete typing across sortable operations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
Review effort: Lite
Findings: 4
Open (8)
_fireRemoveEventis defined to… · New_keydownHandlernow requirese: DragEvent, but there is at least one call site that provides no… · New_keydownHandleris invoked without an event argument here, but it now assumeseis present and… · Newneverfor the handler argument makesDraggableBasePropertiesunusable for correctly-typed… · NewplaceholderClassNameis typed as requiredstring, but later code treats it as possibly… · NewcorrectedWidthcan be astring(including values like'100px'depending on upstream… · New
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The extensive refactor touches core drag-and-drop event, scrolling, and DOM paths and warrants final human validation.
Review effort: Balanced
Findings: None
Resolved since last review (8)
_keydownHandleris invoked without an event argument here, but it now assumeseis present and…_keydownHandlernow requirese: DragEvent, but there is at least one call site that provides no…_fireRemoveEventis defined to…correctedWidthcan be astring(including values like'100px'depending on upstream…placeholderClassNameis typed as requiredstring, but later code treats it as possibly…neverfor the handler argument makesDraggableBasePropertiesunusable for correctly-typed…
…nd element shown handlers (DevExpress#5275)
EugeniyKiyashko
force-pushed
the
typescript/draggable_sortable/typing_5275
branch
from
October 6, 2026 11:32
25cc758 to
8f89606
Compare
anna-shakhova
approved these changes
Oct 6, 2026
| export type DragEventArgs = Cancelable & { | ||
| event: DragEvent; | ||
| itemData: unknown; | ||
| itemElement: unknown; |
Contributor
There was a problem hiding this comment.
can we type it as dxElementWrapper, similar to DragStartArgs?
Contributor
Author
There was a problem hiding this comment.
will improve in the next PRs
| const clone = this.option('clone'); | ||
| const $container = this._getContainer(); | ||
| let template = this.option('dragTemplate'); | ||
| const dragTemplate = this.option('dragTemplate'); |
Contributor
There was a problem hiding this comment.
Suggested change
| const dragTemplate = this.option('dragTemplate'); | |
| const { clone, dragTemplate } = this.option(); |
Contributor
Author
There was a problem hiding this comment.
will improve in the next PRs
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.