Repository navigation
Charts: import the internal modules instead of their public re-exports - #35498
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A public runtime re-export remains and the pie chart now disables all ESLint validation.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Migrates visualization internals from public @js re-exports to direct @ts modules while refining supporting internal typings.
Changes:
- Replaced public core/event imports across visualization components.
- Added internal type signatures and removed obsolete suppressions.
- Updated supporting core APIs for direct internal consumption.
| File | Description |
|---|---|
packages/devextreme/js/__internal/viz/vector_map/vector_map.ts |
Uses internal component registration. |
packages/devextreme/js/__internal/viz/vector_map/tracker.ts |
Migrates DOM and event imports. |
packages/devextreme/js/__internal/viz/vector_map/projection.main.ts |
Uses internal extend utility. |
packages/devextreme/js/__internal/viz/vector_map/map_layer.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/vector_map/legend.ts |
Migrates iteration utilities. |
packages/devextreme/js/__internal/viz/vector_map/layout.ts |
Uses internal iterator. |
packages/devextreme/js/__internal/viz/vector_map/event_emitter.ts |
Uses internal callbacks. |
packages/devextreme/js/__internal/viz/vector_map/data_exchanger.ts |
Uses internal callbacks. |
packages/devextreme/js/__internal/viz/utils.ts |
Uses internal iterator. |
packages/devextreme/js/__internal/viz/tree_map/tree_map.base.ts |
Migrates registration and common utilities. |
packages/devextreme/js/__internal/viz/tree_map/tiling.ts |
Uses internal type utility. |
packages/devextreme/js/__internal/viz/tree_map/states.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/tree_map/node.ts |
Uses internal extend utility. |
packages/devextreme/js/__internal/viz/tree_map/colorizing.ts |
Uses internal noop. |
packages/devextreme/js/__internal/viz/tree_map/api.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/translators/translator2d.ts |
Migrates date, math, and type utilities. |
packages/devextreme/js/__internal/viz/translators/range.ts |
Migrates extend and type utilities. |
packages/devextreme/js/__internal/viz/translators/logarithmic_translator.ts |
Uses internal type utility. |
packages/devextreme/js/__internal/viz/translators/interval_translator.ts |
Migrates date and math utilities. |
packages/devextreme/js/__internal/viz/translators/datetime_translator.ts |
Uses internal date utilities. |
packages/devextreme/js/__internal/viz/translators/category_translator.ts |
Migrates math and type utilities. |
packages/devextreme/js/__internal/viz/themes.ts |
Migrates theme and core imports. |
packages/devextreme/js/__internal/viz/sparklines/sparkline.ts |
Migrates registration and type imports. |
packages/devextreme/js/__internal/viz/sparklines/bullet.ts |
Uses internal component registration. |
packages/devextreme/js/__internal/viz/sparklines/base_sparkline.ts |
Migrates renderer and event imports. |
packages/devextreme/js/__internal/viz/series/stacked_series.ts |
Migrates common and object utilities. |
packages/devextreme/js/__internal/viz/series/scatter_series.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/series/range_series.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/series/points/symbol_point.ts |
Migrates point utilities. |
packages/devextreme/js/__internal/viz/series/points/stock_point.ts |
Migrates extend and type utilities. |
packages/devextreme/js/__internal/viz/series/points/range_symbol_point.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/series/points/range_bar_point.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/series/points/polar_point.ts |
Migrates extend and type utilities. |
packages/devextreme/js/__internal/viz/series/points/pie_point.ts |
Migrates extend and type utilities. |
packages/devextreme/js/__internal/viz/series/points/label.ts |
Uses internal formatter and utilities. |
packages/devextreme/js/__internal/viz/series/points/candlestick_point.ts |
Uses internal extend utility. |
packages/devextreme/js/__internal/viz/series/points/bubble_point.ts |
Uses internal extend utility. |
packages/devextreme/js/__internal/viz/series/points/base_point.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/series/points/bar_point.ts |
Uses internal extend utility. |
packages/devextreme/js/__internal/viz/series/pie_series.ts |
Migrates common and debug utilities. |
packages/devextreme/js/__internal/viz/series/line_series.ts |
Migrates math and object utilities. |
packages/devextreme/js/__internal/viz/series/helpers/range_data_calculator.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/series/helpers/display_format_parser.ts |
Uses internal localization. |
packages/devextreme/js/__internal/viz/series/financial_series.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/series/bubble_series.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/series/base_series.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/series/bar_series.ts |
Migrates iteration and type utilities. |
packages/devextreme/js/__internal/viz/series/area_series.ts |
Migrates extend and clone utilities. |
packages/devextreme/js/__internal/viz/sankey/tooltip.ts |
Migrates extend and type utilities. |
packages/devextreme/js/__internal/viz/sankey/sankey.ts |
Migrates registration and utilities. |
packages/devextreme/js/__internal/viz/sankey/node_item.ts |
Uses internal type utility. |
packages/devextreme/js/__internal/viz/sankey/link_item.ts |
Uses internal type utility. |
packages/devextreme/js/__internal/viz/range_selector/tracker.ts |
Migrates DOM, support, and event imports. |
packages/devextreme/js/__internal/viz/range_selector/sliders_controller.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/range_selector/series_data_source.ts |
Migrates collection and type utilities. |
packages/devextreme/js/__internal/viz/range_selector/range_selector.ts |
Migrates registration, formatting, and utilities. |
packages/devextreme/js/__internal/viz/range_selector/common.ts |
Uses internal device and browser modules. |
packages/devextreme/js/__internal/viz/polar_chart.ts |
Migrates registration and common utilities. |
packages/devextreme/js/__internal/viz/pie_chart.ts |
Migrates imports and changes lint suppression. |
packages/devextreme/js/__internal/viz/palette.ts |
Uses internal color utilities. |
packages/devextreme/js/__internal/viz/gauges/tracker.ts |
Migrates DOM, readiness, and event imports. |
packages/devextreme/js/__internal/viz/gauges/theme_manager.ts |
Uses internal extend utility. |
packages/devextreme/js/__internal/viz/gauges/linear_gauge.ts |
Migrates registration and utilities. |
packages/devextreme/js/__internal/viz/gauges/common.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/gauges/circular_gauge.ts |
Migrates registration and utilities. |
packages/devextreme/js/__internal/viz/gauges/base_range_container.ts |
Migrates iterator and type utilities. |
packages/devextreme/js/__internal/viz/gauges/base_indicators.ts |
Migrates extend and iterator utilities. |
packages/devextreme/js/__internal/viz/gauges/base_gauge.ts |
Uses internal formatter and utilities. |
packages/devextreme/js/__internal/viz/gauges/bar_gauge.ts |
Migrates registration, math, and object utilities. |
packages/devextreme/js/__internal/viz/funnel/tracker.ts |
Uses internal type utility. |
packages/devextreme/js/__internal/viz/funnel/tooltip.ts |
Uses internal noop. |
packages/devextreme/js/__internal/viz/funnel/label.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/funnel/item.ts |
Uses internal type utility. |
packages/devextreme/js/__internal/viz/funnel/funnel.ts |
Migrates registration and common utilities. |
packages/devextreme/js/__internal/viz/core/utils.ts |
Migrates color, date, math, and type imports. |
packages/devextreme/js/__internal/viz/core/tooltip.ts |
Migrates renderer, DOM, formatting, and utilities. |
packages/devextreme/js/__internal/viz/core/title.ts |
Migrates extend and type utilities. |
packages/devextreme/js/__internal/viz/core/series_family.ts |
Migrates date, math, and common utilities. |
packages/devextreme/js/__internal/viz/core/renderers/renderer.ts |
Migrates renderer internals and event engine. |
packages/devextreme/js/__internal/viz/core/renderers/animation.ts |
Uses internal animation frame module. |
packages/devextreme/js/__internal/viz/core/plaque.ts |
Migrates extend and type utilities. |
packages/devextreme/js/__internal/viz/core/layout_element.ts |
Uses internal noop. |
packages/devextreme/js/__internal/viz/core/helpers.ts |
Migrates common and window utilities. |
packages/devextreme/js/__internal/viz/core/export.ts |
Migrates renderer, localization, events, and themes. |
packages/devextreme/js/__internal/viz/core/errors_warnings.ts |
Uses internal error modules. |
packages/devextreme/js/__internal/viz/core/data_source.ts |
Uses internal data helper and noop. |
packages/devextreme/js/__internal/viz/core/center_template.ts |
Uses internal noop. |
packages/devextreme/js/__internal/viz/core/base_widget.utils.ts |
Migrates resize and string utilities. |
packages/devextreme/js/__internal/viz/core/base_widget.ts |
Migrates renderer, events, and utility imports. |
packages/devextreme/js/__internal/viz/core/base_theme_manager.ts |
Migrates collection and type utilities. |
packages/devextreme/js/__internal/viz/core/annotations.ts |
Migrates DOM and event imports with event typing. |
packages/devextreme/js/__internal/viz/components/tracker.ts |
Migrates DOM and event imports. |
packages/devextreme/js/__internal/viz/components/parse_utils.ts |
Migrates date serialization and type utilities. |
packages/devextreme/js/__internal/viz/components/legend.ts |
Migrates deferred and common utilities. |
packages/devextreme/js/__internal/viz/components/data_validator.ts |
Migrates extend and type utilities. |
packages/devextreme/js/__internal/viz/components/chart_theme_manager.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/chart.ts |
Migrates registration and chart utilities. |
packages/devextreme/js/__internal/viz/chart_components/zoom_and_pan.ts |
Migrates drag and wheel event imports. |
packages/devextreme/js/__internal/viz/chart_components/tracker.ts |
Migrates DOM, events, and utilities. |
packages/devextreme/js/__internal/viz/chart_components/shutter_zoom.ts |
Uses internal drag events. |
packages/devextreme/js/__internal/viz/chart_components/scroll_bar.ts |
Migrates drag events and adds event typing. |
packages/devextreme/js/__internal/viz/chart_components/multi_axes_synchronizer.ts |
Migrates debug and math utilities. |
packages/devextreme/js/__internal/viz/chart_components/layout_manager.ts |
Uses internal type utility. |
packages/devextreme/js/__internal/viz/chart_components/crosshair.ts |
Uses internal extend utility. |
packages/devextreme/js/__internal/viz/chart_components/base_chart.ts |
Migrates event and common utilities. |
packages/devextreme/js/__internal/viz/chart_components/advanced_chart.ts |
Migrates common and canvas utilities. |
packages/devextreme/js/__internal/viz/axes/xy_axes.ts |
Migrates formatter and date utilities. |
packages/devextreme/js/__internal/viz/axes/tick.ts |
Migrates deferred and type utilities. |
packages/devextreme/js/__internal/viz/axes/tick_generator.ts |
Migrates date, math, and type utilities. |
packages/devextreme/js/__internal/viz/axes/strip.ts |
Migrates extend and type utilities. |
packages/devextreme/js/__internal/viz/axes/smart_formatter.ts |
Migrates formatter, date, math, and type imports. |
packages/devextreme/js/__internal/viz/axes/polar_axes.ts |
Migrates common utilities. |
packages/devextreme/js/__internal/viz/axes/datetime_breaks.ts |
Uses internal date utilities. |
packages/devextreme/js/__internal/viz/axes/constant_line.ts |
Uses internal type utility. |
packages/devextreme/js/__internal/viz/axes/base_axis.ts |
Migrates formatter, deferred, math, and type imports. |
packages/devextreme/js/__internal/ui/themes.ts |
Refines optional theme argument typing. |
packages/devextreme/js/__internal/core/utils/m_deferred.ts |
Adds deferred and when signatures. |
packages/devextreme/js/__internal/core/utils/m_common.ts |
Makes grep inversion optional. |
packages/devextreme/js/__internal/core/localization/message.ts |
Allows formatter arguments. |
packages/devextreme/js/__internal/core/format_helper.ts |
Refines optional formatting parameters. |
packages/devextreme/js/__internal/core/component_registrator.ts |
Generalizes component constructor typing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmlvr
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.