Repository navigation
T1336404 - ColorBox - Clearing the value with the delete/backspace key converts it to the HSV format when applyValueMode is set to "instantly" - #35501
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Targeted source inspection confirms the clearing behavior and conditional test expectations, with no unresolved blocking findings.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes ColorBox clearing in instant-apply mode so deleting the input does not restore a formatted color value.
Changes:
- Normalizes empty strings to
nullwhen synchronizing the color palette. - Preserves empty values during palette updates.
- Adds regression tests with alpha-channel editing enabled and disabled.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/colorBox.tests.js | Tests clearing and palette reset in both alpha modes. |
| packages/devextreme/js/__internal/ui/color_box/color_box.ts | Normalizes empty palette values and prevents unwanted value propagation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- check the user-visible result (value, text, a single valueChanged) instead of the ColorView value
- add cases without color selecting, with a closed popup, option('value', '') and applyValueMode = useButtons
- add a guard that a color can be applied after clearing
dmlvr
enabled auto-merge
October 6, 2026 12:43
EugeniyKiyashko
approved these changes
Oct 6, 2026
dmlvr
disabled auto-merge
October 6, 2026 12:45
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 6, 2026
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.