Repository navigation
FilterBuilder, Draggable, Sortable: remove m_ prefix - #35525
Merged
EugeniyKiyashko merged 2 commits intoOct 7, 2026
Merged
EugeniyKiyashko merged 2 commits into
EugeniyKiyashko merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Test-only grid fields now survive production debug stripping and should remain enclosed by debug guards.
Review effort: Balanced
Findings: 1
What changed in this PR
Standardizes internal FilterBuilder, Draggable, and Sortable module names by removing the m_ prefix while preserving public entry points.
Changes:
- Renames internal modules and updates consumers and tests.
- Updates CODEOWNERS for renamed files.
- Adjusts related debug-only code formatting and placement.
| File | Description |
|---|---|
.github/CODEOWNERS |
Updates ownership paths for renamed modules. |
packages/devextreme/js/__internal/draggable.ts |
Renames Draggable implementation and repositions a test accessor. |
packages/devextreme/js/__internal/sortable.ts |
Renames Sortable implementation and updates its Draggable import. |
packages/devextreme/js/__internal/filter_builder/between.ts |
Renames the between-operation module. |
packages/devextreme/js/__internal/filter_builder/filter_builder.ts |
Renames FilterBuilder implementation imports. |
packages/devextreme/js/__internal/filter_builder/filter_operations_dictionary.ts |
Renames the operation dictionary module. |
packages/devextreme/js/__internal/filter_builder/utils.ts |
Renames FilterBuilder utility imports. |
packages/devextreme/js/__internal/filter_builder/__tests__/utils.test.ts |
Updates the utility test import. |
packages/devextreme/js/__internal/ui/color_box/color_view.ts |
Updates the Draggable import. |
packages/devextreme/js/__internal/integration/knockout/component_registrator.ts |
Updates the Draggable import. |
packages/devextreme/js/__internal/ui/list/list.edit.decorator.reorder.ts |
Updates the Sortable import. |
packages/devextreme/js/__internal/ui/form/form.layout_manager.ts |
Adjusts debug argument comma formatting. |
packages/devextreme/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts |
Changes debug guards around test-only fields. |
packages/devextreme/js/__internal/grids/grid_core/filter_builder/m_filter_builder.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/grid_core/filter_panel/m_filter_panel.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/grid_core/filter_sync/extenders/filter_sync_column_headers_view.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/grid_core/filter_sync/filter_sync.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/grid_core/filter_sync/m_filter_custom_operations.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/grid_core/filter_sync/utils.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/new/card_view/header_panel/header_panel.tsx |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/new/grid_core/filtering/filter_sync/controller.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/new/grid_core/filtering/filter_sync/utils.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/new/grid_core/filtering/header_filter/view_controller.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/new/grid_core/filtering/legacy_filter_custom_operations.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/__internal/grids/new/grid_core/filtering/utils.ts |
Updates FilterBuilder utility imports. |
packages/devextreme/js/ui/draggable.js |
Points the public entry point to the renamed module. |
packages/devextreme/js/ui/filter_builder.js |
Points the public entry point to the renamed module. |
packages/devextreme/js/ui/sortable.js |
Points the public entry point to the renamed module. |
packages/devextreme/testing/tests/DevExpress.ui.widgets/filterBuilderParts/commonTests.js |
Updates the FilterBuilder test import. |
packages/devextreme/testing/tests/DevExpress.ui.widgets/filterBuilderParts/eventsTests.js |
Updates the FilterBuilder test import. |
packages/devextreme/testing/tests/DevExpress.ui.widgets/filterBuilderParts/keyboardNavigation.js |
Updates the FilterBuilder test import. |
packages/devextreme/testing/tests/DevExpress.ui.widgets/filterBuilderParts/utilsTests.js |
Updates renamed utility imports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
anna-shakhova
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.