Repository navigation
Grids: type m_grid_view - #35598
Open
anna-shakhova wants to merge 3 commits into
Open
Grids: type m_grid_view#35598anna-shakhova wants to merge 3 commits into
anna-shakhova wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The master-detail resize callback can call .done() on an undefined result when the detail grid becomes invisible.
1 open finding
What changed in this PR
Adds stronger TypeScript typing to grid view and resizing logic while preserving existing behavior.
Changes:
- Types grid view controllers, methods, deferreds, and view lookups.
- Replaces legacy iterator patterns with typed array operations.
- Updates master-detail handling for the typed
updateDimensionsresult.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/views/m_grid_view.ts |
Adds types and modernizes grid sizing/view logic. |
packages/devextreme/js/__internal/grids/grid_core/master_detail/m_master_detail.ts |
Adapts master-detail resizing to the new return type. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
anna-shakhova
force-pushed
the
type_grid_view_main
branch
from
October 9, 2026 13:45
c7bdb72 to
8028ad6
Compare
anna-shakhova
commented
Oct 9, 2026
| ): ModuleType<ResizingController> => class AdaptivityResizingViewControllerExtender extends Base { | ||
| public dispose() { | ||
| super.dispose.apply(this, arguments as any); | ||
| clearTimeout(this._updateScrollableTimeoutID); |
Contributor
Author
There was a problem hiding this comment.
_updateScrollableTimeoutID was never set, so remove unnecessary method overload
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.