update typing skill

[anna-shakhova]

No description provided.

[Copilot]

🟡 Changes recommended

Two instructions inaccurately describe iteration and transpilation behavior and could cause incorrect typing work.

2 open findings

• Avoid flagging preserved rest parameters as stale artifacts · New
• Ensure sparse arrays and callback parameters preserve each semantics · New

What changed in this PR

Updates the typing skill with expanded workflow guidance, behavior-preservation traps, grid conventions, and TypeScript fixes.

Changes:

• Adds typing workflow and verification guidance.
• Documents additional refactoring traps and grid-specific patterns.
• Expands recommended fixes for TypeScript and ESLint issues.

File	Description
SKILL.md	Updates workflow and verification commands.
traps.md	Adds behavior-change warnings.
grids.md	Adds grid typing conventions.
fixes.md	Expands typing fixes and workarounds.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

Several new instructions reference obsolete paths or recommend an unsafe postfix-increment replacement.

0 open findings

2 resolved since last review

• Ensure sparse arrays and callback parameters preserve each semantics
• Avoid flagging preserved rest parameters as stale artifacts

Previously missed (4)

In code that hasn't changed since last review

Update coordination check to the current shared types path

.claude/​skills/​typing-m-files/​SKILL.md:53

This coordination check targets a file that no longer exists. The shared grid hub is packages/devextreme/js/__internal/grids/grid_core/types.ts, so filtering for grid_core/m_types.ts silently returns no matching PRs and defeats the new conflict-avoidance step. Update both the example and the query to the current path.

Limit string increment replacement to standalone expressions

.claude/​skills/​typing-m-files/​fixes.md:141

The string-operand recommendation is unsafe when the value of postfix ++ is consumed: postfix returns the old numeric value, but x = Number(x) + 1 returns the incremented value. Restrict this replacement to standalone increments and document that expression uses need to preserve the old numeric result.

Correct obsolete paths in the new type placement rule

.claude/​skills/​typing-m-files/​grids.md:13

This newly added rule names two paths that are no longer present: the shared type hub is grid_core/types.ts, and the modules implementation is now under grid_core/modules/modules.ts. As written, it directs agents to add types to a nonexistent m_types.ts file.

Preserve postfix increment result when its value is consumed

.claude/​skills/​typing-m-files/​traps.md:8

x = Number(x) + 1 is equivalent only when the increment's expression result is discarded. Postfix x++ evaluates to the old numeric value, while the assignment evaluates to the new value, so replacing a consumed increment (for example in an argument or template) changes behavior. Please qualify this guidance and require preserving the old numeric value when it is consumed.

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The documentation updates are internally consistent and align with the current repository structure and tooling.

0 open findings

🧠 Review effort: Balanced