Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The OpenAI compatibility override can preserve unsupported additionalProperties values instead of enforcing false.
1 open finding
What changed in this PR
Migrates the DataGrid and TreeList AI Assistant to Zod 4’s native JSON Schema generation and removes the direct zod-to-json-schema dependency.
Changes:
- Upgrades Zod and removes
zod-to-json-schema. - Adds OpenAI schema normalization and updates Zod 4 typings.
- Adds comprehensive response-schema tests.
| File | Description |
|---|---|
pnpm-workspace.yaml |
Updates the Zod catalog dependency. |
pnpm-lock.yaml |
Refreshes resolved dependencies. |
packages/devextreme/testing/runner/lib/importMap.ts |
Removes the obsolete shim mapping. |
packages/devextreme/testing/helpers/esm-shims/zod.js |
Stubs native JSON Schema conversion. |
packages/devextreme/testing/helpers/esm-shims/zod-to-json-schema.js |
Removes the obsolete shim. |
packages/devextreme/package.json |
Removes the converter dependency. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/utils.ts |
Adds OpenAI schema normalization. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/types.ts |
Updates empty-schema type inference. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands.ts |
Uses native Zod JSON Schema generation. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/utils.ts |
Migrates nullable optional schema typing. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/__tests__/utils.test.ts |
Tests OpenAI normalization. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/__tests__/grid_commands.test.ts |
Updates schema-generation tests. |
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/__tests__/response_schema.test.ts |
Verifies complete generated schemas. |
NOTICE.txt |
Removes the former dependency notice. |
e2e/wrappers/package.json |
Removes the converter dependency. |
apps/demos/package.json |
Removes the converter dependency. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DataGrid and TreeList AI Assistant moved to
zod4.zod-to-json-schemadependency removedHow
Response schema built with native
z.toJSONSchema,makeOpenAICompatibleoverride keeps OpenAI rules (all fields required,additionalProperties: false). Shared sub-schemas now inlined instead of$ref, filter value descriptions now reach the AI