Repository navigation
Grids: type keyboard navigation controllers - #35667
Merged
bit-byte0 merged 7 commits intoOct 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently improve internal typing without introducing unresolved functional issues.
0 open findings
What changed in this PR
Adds stronger TypeScript coverage to DataGrid keyboard navigation and relocates DataGrid-specific controller typing.
Changes:
- Types keyboard events, positions, views, columns, and controller methods.
- Moves shared navigation interfaces into
types.ts. - Registers the group-panel controller through DataGrid module augmentation.
| File | Description |
|---|---|
grid_core/types.ts |
Removes the DataGrid-specific controller dependency. |
grid_core/keyboard_navigation/types.ts |
Adds shared navigation and event types. |
grid_core/keyboard_navigation/m_keyboard_navigation.ts |
Uses relocated position and scroll types. |
grid_core/keyboard_navigation/m_keyboard_navigation_core.ts |
Types the core controller and deferred scrolling flow. |
grid_core/keyboard_navigation/m_headers_keyboard_navigation.ts |
Types header navigation handlers and columns. |
grid_core/keyboard_navigation/m_column_keyboard_navigation_core.ts |
Types column movement and focus APIs. |
grid_core/keyboard_navigation/const.ts |
Removes interfaces relocated to types.ts. |
data_grid/keyboard_navigation/types.ts |
Defines the shared DataGrid mixin base type. |
data_grid/keyboard_navigation/m_group_panel_keyboard_navigation.ts |
Types group-panel navigation and augments the controller registry. |
data_grid/keyboard_navigation/m_column_keyboard_navigation_mixin.ts |
Types grouping keyboard behavior and mixin methods. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bit-byte0
changed the title
|
|
||
| protected renderCompleted(e: any) { | ||
| protected renderCompleted(e?: unknown): void { | ||
| const { needToRestoreFocus } = this; |
Contributor
There was a problem hiding this comment.
lets use this.needToRestoreFocus inline
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| protected renderCompleted(e: any): void { | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars -- overridable signature | ||
| protected renderCompleted(e?: unknown): void { |
Contributor
There was a problem hiding this comment.
lets type e from usage in packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
anna-shakhova
previously approved these changes
Oct 15, 2026
bit-byte0
force-pushed
the
refactor/type-keyboard-navigation-main
branch
from
October 15, 2026 09:56
cd122fa to
714e95d
Compare
Alyar666
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Typed DataGrid keyboard navigation controllers: core, column core, headers, column mixin, group panel
How
Keydown handlers use the keyboard processor event, views and columns got real types. Position types moved to types.ts, the group panel controller is registered in the controller registry from data_grid instead of grid_core