Repository navigation
Scrollable, ScrollView: remove the undocumented x/y alias from scrollTo and scrollBy - #35716
Merged
anna-shakhova merged 4 commits intoOct 16, 2026
Merged
Conversation
anna-shakhova
marked this pull request as ready for review
October 15, 2026 12:40
anna-shakhova
changed the title
anna-shakhova
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing shared x/y aliases silently breaks previously supported scrolling calls in existing applications.
1 open finding
What changed in this PR
Restores PivotGrid’s placeholder tables during virtual scrolling and standardizes scrolling coordinates across shared utilities and tests.
Changes:
- Uses
left/topto position PivotGrid placeholder tables. - Adds regression tests for visibility, positioning, and right-to-left layouts.
- Migrates scrolling calls and removes shared
x/yalias handling.
| File | Description |
|---|---|
| packages/testcafe-models/dataGrid/index.ts | Updates scroll helper parameter types. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/treeViewParts/focusing.js | Migrates focus-test scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/tileView.tests.js | Updates directional scroll properties. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/tileView.markup.tests.js | Updates markup-test scroll properties. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/sortable.tests.js | Migrates sortable scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/scrollView.tests.js | Migrates ScrollView test coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/scrollableParts/scrollable.api.tests.js | Removes coordinate-alias coverage. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.treeList/virtualScrolling.integration.tests.js | Migrates virtual-scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.treeList/treeList.tests.js | Migrates TreeList scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/virtual_scrolling.timeline.tests.js | Updates timeline offsets and diagnostics. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/virtual_scrolling.monthView.tests.js | Updates month-view offsets and diagnostics. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/virtual_scrolling.integration.tests.js | Migrates virtual-scroll scenarios and diagnostics. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.workSpace.tests.js | Migrates workspace scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/dragAndDropAppointments.tests.js | Migrates appointment-dragging scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.week.based.views.tests.js | Migrates week-view scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.editing.tests.js | Migrates editing-test scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.tests.js | Updates placeholder-table scrolling tests. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/fieldChooser.tests.js | Migrates field-chooser scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/virtualScrolling.integration.tests.js | Migrates virtual-scroll test coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/selection.integration.tests.js | Migrates selection-test scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/scrolling.integration.tests.js | Migrates scrolling integration coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/rowsView.tests.js | Migrates rows-view scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/masterDetail.integration.tests.js | Migrates master-detail scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.tests.js | Migrates focus-test scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.integration.tests.js | Migrates focus integration coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/editing.tests.js | Migrates editing-test scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/editing.integration.tests.js | Migrates editing integration coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/dataGrid.tests.js | Migrates template-test scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/columnFixing.tests.js | Migrates fixed-column scroll coordinates. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/columnChooser.integration.tests.js | Migrates chooser-test scroll coordinates. |
| packages/devextreme/js/__internal/ui/scroll_view/utils/convert_location.ts | Removes coordinate aliases from conversion. |
| packages/devextreme/js/__internal/ui/scroll_view/scrollable.ts | Removes coordinate aliases from normalization. |
| packages/devextreme/js/__internal/grids/pivot_grid/headers_area/m_headers_area.ts | Corrects header placeholder positioning. |
| packages/devextreme/js/__internal/grids/pivot_grid/headers_area/m_headers_area.test.ts | Adds header placeholder regression tests. |
| packages/devextreme/js/__internal/grids/pivot_grid/data_area/m_data_area.ts | Corrects data placeholder positioning. |
| packages/devextreme/js/__internal/grids/pivot_grid/data_area/m_data_area.test.ts | Adds visibility and right-to-left regression tests. |
| e2e/testcafe-devextreme/tests/scheduler/helpers/utils.ts | Updates Scheduler scrolling helper. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/fixed/positions.ts | Migrates fixed-position scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/fixed/bandColumnSecondCases.ts | Migrates band-column scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/fixed/bandColumnFirstCases.ts | Migrates band-column scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withVirtualScrolling.ts | Migrates virtual-scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withVirtualColumns.ts | Migrates virtual-column scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withRowSelection.ts | Migrates selection-test scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withMasterDetail.ts | Migrates master-detail scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withGrouping.ts | Migrates grouping-test scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withFilterRow.ts | Migrates filter-row scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withEditing.ts | Migrates editing-test scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withBandColumns.ts | Migrates band-column scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withAdaptability.ts | Migrates adaptive-layout scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/stickyColumns.ts | Migrates sticky-column scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/stickyColumnResizing.ts | Migrates resizing-test scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/stickyColumnReordering.ts | Migrates reordering-test scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/virtualColumns/visual.ts | Migrates virtual-column visual tests. |
| e2e/testcafe-devextreme/tests/dataGrid/common/virtualColumns/functional.ts | Migrates virtual-column functional tests. |
| e2e/testcafe-devextreme/tests/dataGrid/common/validation/validationPopup.ts | Migrates validation-popup scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/scrolling.ts | Migrates scrolling regression scenarios. |
| e2e/testcafe-devextreme/tests/dataGrid/common/rowDragging/functional.ts | Migrates row-dragging scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/pager.ts | Migrates pager-test scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/masterDetail/visual.ts | Migrates master-detail visual tests. |
| e2e/testcafe-devextreme/tests/dataGrid/common/masterDetail/functional.ts | Migrates master-detail functional tests. |
| e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/virtualColumns.functional.ts | Migrates virtual-column navigation coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/startEditing.functional.ts | Migrates keyboard-editing scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/keyboardNavigation.visual.ts | Migrates navigation visual-test coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/columnReordering.visual.ts | Migrates keyboard-reordering scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/headerFilter/headerFilter.ts | Migrates header-filter scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/focus/focusedRow/focusedRow.ts | Migrates focused-row scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/focus/focus.ts | Migrates focus-test scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/fixedColumns/visual.ts | Migrates fixed-column visual tests. |
| e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/visual.ts | Migrates filter-row visual tests. |
| e2e/testcafe-devextreme/tests/dataGrid/common/editing/visual.ts | Updates editing-test scrolling helper. |
| e2e/testcafe-devextreme/tests/dataGrid/common/columnReordering/functional.ts | Migrates column-reordering scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/virtualScrolling.functional.ts | Migrates AI-column virtual-scroll coordinates. |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/functional.ts | Migrates AI-column scroll coordinates. |
| e2e/testcafe-devextreme/tests/common/treeList/scrolling.ts | Migrates TreeList scroll coordinates. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmlvr
approved these changes
Oct 15, 2026
bit-byte0
reviewed
Oct 16, 2026
| x?: number; | ||
| y?: number; | ||
| }> | number): Partial<ScrollOffset> { | ||
| _normalizeLocation(location: Partial<ScrollOffset> | number): Partial<ScrollOffset> { |
Contributor
There was a problem hiding this comment.
{ x, y } calls still compile because of number | any, but they no longer scroll - should we add a breaking-change line to the release notes?
Contributor
Author
There was a problem hiding this comment.
well, it is compiles only due to non-strict public type, docs specify its signature as { top, left }
https://js.devexpress.com/jQuery/Documentation/ApiReference/UI_Components/dxScrollView/Methods/#scrollTotargetLocation
fixing public type is out of scope of this task
|
|
||
| const TABLE_OFFSET = 1000; | ||
| const CELL_SIZES = [100, 120, 300]; | ||
| const POSITION_PAST_TABLE = TABLE_OFFSET + 520; |
Contributor
There was a problem hiding this comment.
520 is the sum of CELL_SIZES, right? Maybe compute it so it stays correct if the sizes change (same in m_data_area.test.ts)
Suggested change
| const POSITION_PAST_TABLE = TABLE_OFFSET + 520; | |
| const POSITION_PAST_TABLE = TABLE_OFFSET + CELL_SIZES.reduce((sum, size) => sum + size, 0); |
bit-byte0
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.