forked from w3c/webcodecs
-
Notifications
You must be signed in to change notification settings - Fork 0
Add Extended HE-AAC to AAC WebCodecs Registration #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Djuffin
wants to merge
3
commits into
main
Choose a base branch
from
extended-he-aac-12508865787470178836
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,10 +36,22 @@ | |
| <pre class='biblio'> | ||
| { | ||
| "iso14496-3": { | ||
| "href": "https://www.iso.org/standard/53943.html", | ||
| "title": "ISO/IEC 14496-3:2009 - Information technology — Coding of audio-visual objects — Part 3: Audio", | ||
| "href": "https://www.iso.org/standard/76383.html", | ||
| "title": "ISO/IEC 14496-3:2019 - Information technology — Coding of audio-visual objects — Part 3: Audio", | ||
| "publisher": "ISO", | ||
| "date": "2009-09" | ||
| "date": "2019-12" | ||
| }, | ||
| "iso23003-3": { | ||
| "href": "https://www.iso.org/standard/76385.html", | ||
| "title": "ISO/IEC 23003-3:2020 - Information technology — MPEG audio technologies — Part 3: Unified speech and audio coding", | ||
| "publisher": "ISO", | ||
| "date": "2020-06" | ||
| }, | ||
| "iso23003-4": { | ||
| "href": "https://www.iso.org/standard/89036.html", | ||
| "title": "ISO/IEC 23003-4:2025 - Information technology — MPEG audio technologies — Part 4: Dynamic range control", | ||
| "publisher": "ISO", | ||
| "date": "2025-03" | ||
| } | ||
| } | ||
| </pre> | ||
|
|
@@ -54,6 +66,7 @@ | |
| - `"mp4a.40.5"` — MPEG-4 HE-AAC v1 (AAC LC + SBR) | ||
| - `"mp4a.40.05"` — MPEG-4 HE-AAC v1 (AAC LC + SBR), leading 0 for Aud-OTI compatibility | ||
| - `"mp4a.40.29"` — MPEG-4 HE-AAC v2 (AAC LC + SBR + PS) | ||
| - `"mp4a.40.42"` — Extended HE-AAC (MPEG-D USAC + MPEG-D DRC) as defined in [[iso23003-3]] and [[iso23003-4]] | ||
| - `"mp4a.67"` — MPEG-2 AAC LC | ||
|
|
||
| EncodedAudioChunk data {#encodedaudiochunk-data} | ||
|
|
@@ -66,14 +79,14 @@ | |
| If the bitstream is in {{AacBitstreamFormat/aac}} format, the | ||
| {{EncodedAudioChunk/[[internal data]]}} of {{EncodedAudioChunk}}s are expected | ||
| to be a raw AAC frame (syntax element `raw_data_block()`), as described in | ||
| section 4.4.2.1 of [[iso14496-3]]. | ||
| section 4.4.2.1 of [[iso14496-3]]. Extended HE-AAC shall be in {{AacBitstreamFormat/aac}} format. | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use "must" instead of "shall" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed "shall" to "must". |
||
|
|
||
| AudioDecoderConfig description {#audiodecoderconfig-description} | ||
| ================================================================ | ||
|
|
||
| If {{AudioDecoderConfig/description}} is present, it is assumed to a | ||
| `AudioSpecificConfig` as defined in [[iso14496-3]] section 1.6.2.1, Table 1.15, | ||
| and the bitstream is assumed to be in {{AacBitstreamFormat/aac}}. | ||
| If {{AudioDecoderConfig/description}} is present, it is assumed to be an | ||
| `AudioSpecificConfig` as defined in [[iso14496-3]] section 1.6.2.1, Table 1.19, | ||
| and the bitstream is assumed to be in {{AacBitstreamFormat/aac}} format. | ||
|
|
||
| If the {{AudioDecoderConfig/description}} is not present, the bitstream is | ||
| assumed to be in {{AacBitstreamFormat/adts}} format. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add xHE-AAC in parenthesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added (xHE-AAC) as requested.