Repository navigation
Conversation
Refactored SVG export by splitting `SvgXmlWriter` into `SvgDocumentBuilder`, `SvgEntityWriter`, `SvgStyleWriter`, and `CadXmlWriter` for better separation of concerns. Updated `SvgExporter` to use the new builder. Simplified `SvgConfiguration` and removed inheritance. Added `AssemblyInfo.cs` with strong-naming and test visibility. Cleaned up test project references.
Refactored SVG export pipeline for improved structure and maintainability. Moved color handling to CadXmlWriter and centralized PaperSpace logic. Updated SvgDocumentBuilder to use XDocument for merging and wrap entities in <svg>. SvgStyleWriter now outputs CSS styles for layers and entities. Entities include id and class attributes for better SVG styling and identification. Cleaned up redundant code and improved attribute handling.
Refactored SVG writer classes to improve separation of concerns and code clarity. Moved color and line weight formatting to CadXmlWriter, updated SvgStyleWriter to delegate XML writing, and unified document writing in SvgDocumentBuilder. Cleaned up method names, removed unused usings, and improved CSS style generation. Updated all usages to match the new structure.
Refactored SvgEntityWriter to use composition over inheritance by delegating XML writing to a private CadXmlWriter instance. Moved SVG formatting utilities to CadXmlWriter and updated all usages. Updated SvgDocumentBuilder to pass the writer instance. Cleaned up obsolete code and improved separation of concerns for better maintainability.
Replaces separate "stroke" and "stroke-width" attributes with a single CSS "style" attribute for SVG entities. Uses StringBuilder to construct style rules, improving maintainability and centralizing SVG styling logic. Handles cases for disabling stroke, custom colors, and line weights.
Introduce DecimalPlaces to SvgConfiguration for controlling SVG number formatting. Refactor SvgConverter and related methods to support decimal precision. Update SvgEntityWriter to batch entities before writing. Remove obsolete methods and improve code organization and clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.