Skip to content

Return false from TryGetCadObject when the object is not of the requested type #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DomCR merged 2 commits into from
Oct 8, 2026
Merged

Return false from TryGetCadObject when the object is not of the requested type #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fed6458
Return false from TryGetCadObject when the object is not of the reque…
ilCosmico Oct 7, 2026
bd79b04
Remove the CadDocumentBuilder test
ilCosmico Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/ACadSharp.Tests/CadDocumentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,4 +443,19 @@ public void SetCurrentTest()
doc.SetCurrent(new MultiLeaderStyle(multiLeaderStyleName));
Assert.True(doc.MLeaderStyles.ContainsKey(multiLeaderStyleName));
}

[Fact]
public void TryGetCadObjectTypeMismatch()
{
CadDocument doc = new CadDocument();

Line line = new Line();
doc.Entities.Add(line);

Assert.True(doc.TryGetCadObject(line.Handle, out Line found));
Assert.Equal(line, found);

Assert.False(doc.TryGetCadObject(line.Handle, out Circle circle));
Assert.Null(circle);
}
}
4 changes: 2 additions & 2 deletions src/ACadSharp/CadDocument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,9 +490,9 @@ public bool TryGetCadObject<T>(ulong handle, out T cadObject)
if (handle == this.Handle)
return false;

if (this._cadObjects.TryGetValue(handle, out IHandledCadObject obj))
if (this._cadObjects.TryGetValue(handle, out IHandledCadObject obj) && obj is T)
{
cadObject = obj as T;
cadObject = (T)obj;
return true;
}

Expand Down
Loading