Skip to content

DimensionStyle: round-trip check for the main arrow block (DIMBLK) - #1295

Merged
DomCR merged 1 commit into
DomCR:masterfrom
thiagomizutamcaa:fix/dimstyle-arrow-block
Oct 16, 2026
Merged

DomCR merged 1 commit into
DomCR:masterfrom
thiagomizutamcaa:fix/dimstyle-arrow-block

Conversation

@thiagomizutamcaa

@thiagomizutamcaa thiagomizutamcaa commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Description

Round-trip check for the main arrow block of a dimension style (DimensionStyle.ArrowBlock, DIMBLK). The fix itself came with #1298.

Tasks done in this PR

  • New DimensionStyleArrowBlock case in WriterSingleObjectTests: a dimension style with a custom arrow block is written and read back (DWG AC1015–AC1032 and DXF AC1015–AC1032); the arrow block must come back by name and the leader arrow must stay null. All 11 cases pass on master and fail when ArrowBlock is not resolved from DIMBLK.

Related Issues / Pull Requests

🤖 Generated with Claude Code

@DomCR DomCR added bug Something isn't working review Contributor PR with an active review. labels Oct 15, 2026
@DomCR

DomCR commented Oct 15, 2026

Copy link
Copy Markdown
Owner

Hi @thiagomizutamcaa,

For the roundtrip check WriterSingleObjectTests.

Remove the comments in the code and is good to go.

Good job!

@DomCR

DomCR commented Oct 15, 2026

Copy link
Copy Markdown
Owner

Duplicated fix:

For this one we can keep the test with the requested change.

The fix itself came with DomCR#1298. This adds the DimensionStyleArrowBlock case to
WriterSingleObjectTests: a dimension style with a custom ArrowBlock is written
and read back (DWG and DXF, every version), and the arrow block must come back
by name while the leader arrow stays null. The case fails when ArrowBlock is
not resolved from DIMBLK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thiagomizutamcaa
thiagomizutamcaa force-pushed the fix/dimstyle-arrow-block branch from 81b25a6 to 814ef67 Compare October 15, 2026 14:51
@thiagomizutamcaa thiagomizutamcaa changed the title DimensionStyle: read the main arrow block (DIMBLK) DimensionStyle: round-trip check for the main arrow block (DIMBLK) Oct 15, 2026
@thiagomizutamcaa

Copy link
Copy Markdown
Contributor Author

Thanks @DomCR! Done:

  • rebased on master — the fix came with fix: resolve the DIMBLK arrow block of a dimension style #1298, so this PR no longer touches the code (and the comments are gone with it);
  • the separate test class is replaced by a DimensionStyleArrowBlock case in WriterSingleObjectTests, checked through AssertRoundtrip (DWG and DXF, every version). It passes on master and fails (11/11) if ArrowBlock is not resolved from DIMBLK.

@DomCR DomCR added the minor Updates the minor version on merge. label Oct 16, 2026
@DomCR
DomCR merged commit 1a44b91 into DomCR:master Oct 16, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working minor Updates the minor version on merge. review Contributor PR with an active review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants