Repository navigation
DimensionStyle: round-trip check for the main arrow block (DIMBLK) - #1295
Merged
Merged
Conversation
2 tasks done
Owner
|
For the roundtrip check Remove the comments in the code and is good to go. Good job! |
DomCR
approved these changes
Oct 15, 2026
Owner
|
Duplicated fix: For this one we can keep the test with the requested change. |
The fix itself came with DomCR#1298. This adds the DimensionStyleArrowBlock case to WriterSingleObjectTests: a dimension style with a custom ArrowBlock is written and read back (DWG and DXF, every version), and the arrow block must come back by name while the leader arrow stays null. The case fails when ArrowBlock is not resolved from DIMBLK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thiagomizutamcaa
force-pushed
the
fix/dimstyle-arrow-block
branch
from
October 15, 2026 14:51
81b25a6 to
814ef67
Compare
Contributor
Author
|
Thanks @DomCR! Done:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Round-trip check for the main arrow block of a dimension style (
DimensionStyle.ArrowBlock,DIMBLK). The fix itself came with #1298.Tasks done in this PR
DimensionStyleArrowBlockcase inWriterSingleObjectTests: a dimension style with a custom arrow block is written and read back (DWG AC1015–AC1032 and DXF AC1015–AC1032); the arrow block must come back by name and the leader arrow must stay null. All 11 cases pass on master and fail whenArrowBlockis not resolved fromDIMBLK.Related Issues / Pull Requests
🤖 Generated with Claude Code