Repository navigation
Read every page of a multi-page blob in the Prototype1b section - #1305
Merged
Merged
Conversation
DomCR
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DwgPrototype1bReader.readDataFieldsreads the (segment index, size) pair of a blob page, jumps to that blob01 segment and reads its data, but it never moves back. From the second page on, the next pair is read from inside the data of the previous page, the segment index is garbage and the read throws anArgumentOutOfRangeException. The exception stops the whole section, so everyModelerGeometryin the drawing ends up withoutAcisData.It happens as soon as one ACIS payload needs more than one blob page, a little over 2 MB in the files I tried. I hit it on a 2013 DWG with a solid stored in 7 pages, and I could reproduce it with a single extruded polygon with a lot of sides.
The loop now saves the position after the pair and goes back to it once the page is read. With the fix the payloads match the ones from the obsolete
DataStoragereader, on that drawing and on the other 2013+ DWG files with solids I have.