Repository navigation
Clone the proxy geometries of an entity only once - #1317
Merged
Merged
Conversation
DomCR
reviewed
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entity.Clone()creates the proxy geometry list of the clone as a copy of the original list and then adds a clone of each geometry to it. The cloned entity ends up with twice the geometries, and the first half are the same instances as the original, so a change to one of them shows up in both entities. Besides direct calls, this happens to every entity cloned throughBlockRecord,InsertandDimension.The list now starts empty, with the original count as capacity, so it holds only the clones. On the DWG files with proxy graphics I tried, the cloned entities now have the same number of geometries as the originals, of the same types and in the same order, and none of them is shared with the original. The test suite passes.