fix: arguments and import errors solves #78 - #86
Open
HadilOwda wants to merge 5 commits into
Open
Conversation
Add "from dynadojo.systems.ca import CASystem" Delete reps in FixedComplexity Add trials = 3 after system_cls Resolves DynaDojo#78
…ASystem, Delete reps=3, add trials = 3 after system_cls
- Add "from dynadojo.systems.ca import CASystem" - Delete "reps = 3' - add "trials = 3" after system_cls
Collaborator
|
Please review https://github.com/DynaDojo/dynadojo/blob/main/CONTRIBUTING.md#pull-request-checklist and edit. Also should make a separate pull request for demos/fc_dnn_nbody_demo.ipynb |
HadilOwda
changed the title
carynbear
requested changes
Jul 19, 2024
carynbear
left a comment
carynbear
left a comment
Collaborator
There was a problem hiding this comment.
Please reset changes to demos/fc_dnn_nbody_demo.ipynb.
demos/fc_cnn_ca_demo.ipynb looks good.
Collaborator
There was a problem hiding this comment.
You should not commit the changes to this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two errors in demos/cnn_ca_demo.ipynb [Resolves #78}
1.
Error: Unexpected argument reps
Solution:
Delete "reps = 3"
Add "trials = 3" after system_cls
Error: CASystem not defined
Solution:
Add "from dynadojo.systems.ca import CASystem"