Change specification for CO2 concentration-driven compsets - option 2#1584
Draft
billsacks wants to merge 2 commits into
Draft
Change specification for CO2 concentration-driven compsets - option 2#1584billsacks wants to merge 2 commits into
billsacks wants to merge 2 commits into
Conversation
We have decided to use the CESM2 scheme for this - with _BGC%BDRD or _BGC%BPRP. In this scheme, concentration-driven is implicit, without any _BGC specifier. See ESCOMP/CMEPS#658 for some relevant discussion.
This was referenced Jun 13, 2026
Member
Author
|
Either this OR #1583 should come in; not both! @klindsay28 or @fvitt do you know which is correct? |
Member
Author
|
Also, we may want to change the aliases for these changed compsets; I'll leave that step up to the CAM group. |
Member
Author
|
I'm coming to think that this is the right option (not #1583), but I want confirmation from others (like @klindsay28 or @fvitt ). See also discussion in ESCOMP/CESM#407. I think this PR should be bit-for-bit, which is good because it would be good to verify that the removals of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have decided to use the CESM2 mechanism for CO2 –
_BGC%BDRD,_BGC%BPRPor no_BGCspecifier rather than aCorEat the end of the time period. This PR makes changes towards that.I'm not sure what the intention was for the compsets that currently had a
Cat the end of the time period. This PR assumes that the intention was that these operate the same as having no BGC specifier (since my understanding is that concentration-driven is implicit, with no BGC specifier).Should be coordinated with ESCOMP/CESM#407.
Note that @gold2718 's changes in #1581 and some additional changes (which may be folded into that PR or may come in separately) are needed for co2_cycle to work correctly.