Fix copper golem container transaction logging - #14
Draft
CheekyNox wants to merge 3 commits into
Draft
Conversation
Implement listener for Copper Golem target validation events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ItemTransportingEntityValidateTargetEvent.Problem
Copper golems transfer items in batches of 16. Repeated target validation and rapid source/destination switching could replace a pending snapshot before it was logged. This caused missing removals, missing additions, and incomplete totals such as 48 removed or 32 added for a completed 64-item transfer.
Verification
removed x16and fouradded x16records.gradlew buildpasses.